Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 27 Nov 2018 14:14:57 +0000 (UTC)
From:      Andrew Rybchenko <arybchik@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r341059 - head/sys/dev/sfxge/common
Message-ID:  <201811271414.wAREEvll060840@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: arybchik
Date: Tue Nov 27 14:14:57 2018
New Revision: 341059
URL: https://svnweb.freebsd.org/changeset/base/341059

Log:
  sfxge(4): retrieve number of MAC stats from NIC
  
  This reports the number of stats (and hence the DMA buffer size)
  for MAC stats. If MC_GET_CAPABABILITIES_V4 is not supported then
  use the legacy Siena-compatible MC_CMD_MAC_NSTATS value.
  
  Submitted by:   Andy Moreton <amoreton at solarflare.com>
  Sponsored by:   Solarflare Communications, Inc.
  Differential Revision:  https://reviews.freebsd.org/D18173

Modified:
  head/sys/dev/sfxge/common/ef10_nic.c
  head/sys/dev/sfxge/common/efx.h
  head/sys/dev/sfxge/common/siena_nic.c

Modified: head/sys/dev/sfxge/common/ef10_nic.c
==============================================================================
--- head/sys/dev/sfxge/common/ef10_nic.c	Tue Nov 27 14:14:45 2018	(r341058)
+++ head/sys/dev/sfxge/common/ef10_nic.c	Tue Nov 27 14:14:57 2018	(r341059)
@@ -1023,7 +1023,7 @@ ef10_get_datapath_caps(
 	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);
 	efx_mcdi_req_t req;
 	uint8_t payload[MAX(MC_CMD_GET_CAPABILITIES_IN_LEN,
-			    MC_CMD_GET_CAPABILITIES_V2_OUT_LEN)];
+			    MC_CMD_GET_CAPABILITIES_V4_OUT_LEN)];
 	efx_rc_t rc;
 
 	if ((rc = ef10_mcdi_get_pf_count(enp, &encp->enc_hw_pf_count)) != 0)
@@ -1035,7 +1035,7 @@ ef10_get_datapath_caps(
 	req.emr_in_buf = payload;
 	req.emr_in_length = MC_CMD_GET_CAPABILITIES_IN_LEN;
 	req.emr_out_buf = payload;
-	req.emr_out_length = MC_CMD_GET_CAPABILITIES_V2_OUT_LEN;
+	req.emr_out_length = MC_CMD_GET_CAPABILITIES_V4_OUT_LEN;
 
 	efx_mcdi_execute_quiet(enp, &req);
 
@@ -1200,6 +1200,16 @@ ef10_get_datapath_caps(
 		    EFX_TUNNEL_MAXNENTRIES;
 	} else {
 		encp->enc_tunnel_config_udp_entries_max = 0;
+	}
+
+	/* Check if firmware supports extended MAC stats. */
+	if (req.emr_out_length_used >= MC_CMD_GET_CAPABILITIES_V4_OUT_LEN) {
+		/* Extended stats buffer supported */
+		encp->enc_mac_stats_nstats = MCDI_OUT_WORD(req,
+		    GET_CAPABILITIES_V4_OUT_MAC_STATS_NUM_STATS);
+	} else {
+		/* Use Siena-compatible legacy MAC stats */
+		encp->enc_mac_stats_nstats = MC_CMD_MAC_NSTATS;
 	}
 
 #undef CAP_FLAGS1

Modified: head/sys/dev/sfxge/common/efx.h
==============================================================================
--- head/sys/dev/sfxge/common/efx.h	Tue Nov 27 14:14:45 2018	(r341058)
+++ head/sys/dev/sfxge/common/efx.h	Tue Nov 27 14:14:57 2018	(r341059)
@@ -1260,6 +1260,8 @@ typedef struct efx_nic_cfg_s {
 	uint32_t		enc_max_pcie_link_gen;
 	/* Firmware verifies integrity of NVRAM updates */
 	uint32_t		enc_nvram_update_verify_result_supported;
+	/* Firmware support for extended MAC_STATS buffer */
+	uint32_t		enc_mac_stats_nstats;
 } efx_nic_cfg_t;
 
 #define	EFX_PCI_FUNCTION_IS_PF(_encp)	((_encp)->enc_vf == 0xffff)

Modified: head/sys/dev/sfxge/common/siena_nic.c
==============================================================================
--- head/sys/dev/sfxge/common/siena_nic.c	Tue Nov 27 14:14:45 2018	(r341058)
+++ head/sys/dev/sfxge/common/siena_nic.c	Tue Nov 27 14:14:57 2018	(r341059)
@@ -185,6 +185,8 @@ siena_board_cfg(
 
 	encp->enc_nvram_update_verify_result_supported = B_FALSE;
 
+	encp->enc_mac_stats_nstats = MC_CMD_MAC_NSTATS;
+
 	return (0);
 
 fail2:

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201811271414.wAREEvll060840>