Date: Mon, 31 Oct 2011 12:51:14 -0700 From: John-Mark Gurney <jmg@funkthat.com> To: Edward Tomasz Napiera?a <trasz@freebsd.org> Cc: freebsd-sparc64@freebsd.org Subject: Re: Fixing bus_dma_tag_create(NULL, ?). Message-ID: <20111031195114.GU25601@funkthat.com> In-Reply-To: <52DDA484-9D3D-4305-9692-ADBD7C68BD0B@FreeBSD.org> References: <52DDA484-9D3D-4305-9692-ADBD7C68BD0B@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Edward Tomasz Napiera?a wrote this message on Mon, Oct 31, 2011 at 14:52 +0100: > On sparc64, calling bus_dma_tag_create(9) with NULL tag will result in instant > panic due to KASSERT. Patch below fixes all the instances I could find. It also fixes > several places unrelated to sparc64, just to give a good example. > > Now, the problem is - the changes are trivial and mechanical, but I have no way > to test most of it, simply because I don't have hardware handled by these drivers. > And I'm not really sure how to proceed from this point. Any ideas? > > Patch can be found at: > > http://people.freebsd.org/~trasz/sparc64-bus_dma_tag_create.diff Maybe posting this patch to -current and -stable would be best. It would give more people the ability to review and test, and be a good reminder to the others that this is the correct usage. I did take a quick look at the patch, and it does look correct. Thanks. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111031195114.GU25601>