From owner-cvs-all  Thu Feb  8 18:20:34 2001
Delivered-To: cvs-all@freebsd.org
Received: from InterJet.dellroad.org (adsl-63-194-81-26.dsl.snfc21.pacbell.net [63.194.81.26])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2564C37B6A0; Thu,  8 Feb 2001 18:20:10 -0800 (PST)
Received: from curve.dellroad.org (curve.dellroad.org [10.1.1.30])
	by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id SAA64007;
	Thu, 8 Feb 2001 18:20:09 -0800 (PST)
Received: (from archie@localhost)
	by curve.dellroad.org (8.9.3/8.9.3) id SAA57781;
	Thu, 8 Feb 2001 18:20:09 -0800 (PST)
	(envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200102090220.SAA57781@curve.dellroad.org>
Subject: Re: cvs commit: src/sys/net if_ethersubr.c
In-Reply-To: <20010208232101.8135E37C191@hub.freebsd.org> "from Bill Paul at
 Feb 8, 2001 03:21:01 pm"
To: Bill Paul <wpaul@FreeBSD.ORG>
Date: Thu, 8 Feb 2001 18:20:09 -0800 (PST)
Cc: asmodai@wxs.nl, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL77 (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Bill Paul writes:
> > >  When we receive an incoming Ethernet frame that was unicast to a
> > >  different hardware address, we should drop it (this should only
> > >  happen in promiscuous mode).
> > 
> > You mean:
> > 
> > In promiscuous mode we don't drop it?  Whilst in normal mode we drop the
> > erroneous unicast frame?
> > 
> > The sentence is a bit ambiguous to my eyes, hence the call for
> > clarification.
> 
> I'm hoping he means: "this should only happen if the IFF_PROMISC flag
> is set on the interface." Sounds like a sanity check to me -- ideally
> the driver should not let this happen -- but I agree, this explanation
> should be clearer.

Sorry.. about that. That is what it means.

The parenthetical remark refers to the reception of a unicast packet
sent to a different address. In non-promicuous mode we won't receive
that packet (assuming the driver isn't broken).

-Archie

__________________________________________________________________________
Archie Cobbs     *     Packet Design     *     http://www.packetdesign.com


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message