From owner-cvs-all Wed Dec 19 0:20:34 2001 Delivered-To: cvs-all@freebsd.org Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by hub.freebsd.org (Postfix) with ESMTP id D997037B417; Wed, 19 Dec 2001 00:20:22 -0800 (PST) Received: (from uucp@localhost) by sax.sax.de (8.9.3/8.9.3) with UUCP id JAA05971; Wed, 19 Dec 2001 09:20:22 +0100 (CET) Received: (from j@localhost) by uriah.heep.sax.de (8.11.6/8.11.6) id fBJ87Ce11000; Wed, 19 Dec 2001 09:07:12 +0100 (MET) (envelope-from j) Date: Wed, 19 Dec 2001 09:07:12 +0100 From: Joerg Wunsch To: Ruslan Ermilov Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/isa fd.c Message-ID: <20011219090712.G97821@uriah.heep.sax.de> Reply-To: Joerg Wunsch Mail-Followup-To: Joerg Wunsch , Ruslan Ermilov , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200112182216.fBIMGX179954@freefall.freebsd.org> <20011219095119.B93645@sunbay.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20011219095119.B93645@sunbay.com>; from ru@FreeBSD.org on Wed, Dec 19, 2001 at 09:51:19AM +0200 X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG As Ruslan Ermilov wrote: > This is because _MACHINE_ARCH is a bogus define. > > On i386's, ``cpp -dM /dev/null'' shows the following: Ah, that's the command i've been looking for... > On alphas, ``cpp -dM /dev/null'' doesn't define "alpha" as 1, > so _MACHINE_ARCH is ``alpha'' (not a string constant!), and > i386 is not defined either, so Well, i think that should be fixed then. > What you should be actually testing is MACHINE_ARCH, but No, since string constants cannot be compared in cpp. > it's still not suitable in this case, because MACHINE_ARCH > is "i386" on PC98. Moreover, MACHINE is also "i386" on > PC98. OK, so PC98 is really specific and needs to be excluded (sigh), but IMHO we should really fix _MACHINE and _MACHINE_ARCH to generate something that is useful for a cpp conditional. If we don't, there's no purpose to pollute the namespace with two pointless macros. -- cheers, J"org .-.-. --... ...-- -.. . DL8DTL http://www.sax.de/~joerg/ NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message