Date: Tue, 12 Apr 2016 21:21:11 -0700 From: NGie Cooper <yaneurabeya@gmail.com> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: Steve Wills <swills@FreeBSD.org>, Ian Lepore <ian@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r297902 - head Message-ID: <1A172401-6B7B-4099-A4C9-228FB4EBFDDB@gmail.com> In-Reply-To: <570DB6C7.6050201@FreeBSD.org> References: <201604130147.u3D1l5F0032629@repo.freebsd.org> <1460512755.52955.18.camel@freebsd.org> <570DB63F.9060907@FreeBSD.org> <570DB6C7.6050201@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Apr 12, 2016, at 20:02, Bryan Drewery <bdrewery@FreeBSD.org> wrote: > >> On 4/12/2016 8:00 PM, Steve Wills wrote: >>> On 04/12/16 09:59 PM, Ian Lepore wrote: >>> >>> More succinctly: >>> >>> .if empty(SVN) >>> SVN!= which svn || which svnlite >>> .endif >> >> Fair enough, that's basically the intent. I think we like to avoid !=, >> at least in ports, and I wanted the logic between src and ports to match >> in this case. > > Yeah, please avoid != where possible. > > If you switch to this then also add .export SVN after the SVN!= line. > > I somewhat like this version more though since /usr/local/bin may not be > in the PATH. Plus it's not set in PATH probably in this portion of the build...
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1A172401-6B7B-4099-A4C9-228FB4EBFDDB>