Date: Thu, 16 Nov 2017 10:04:47 +0100 From: Baptiste Daroussin <bapt@freebsd.org> To: Conrad Meyer <cem@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Allan Jude <allanjude@freebsd.org> Subject: Re: svn commit: r316980 - head/contrib/zstd/programs Message-ID: <20171116090447.sjwtzrwgyuarh7kv@ivaldir.net> In-Reply-To: <CAG6CVpWxxUuT13NL%2B0LbEDW3N91i4-imsXUBrv1jiTcihs25KQ@mail.gmail.com> References: <201704152015.v3FKFiwZ006836@repo.freebsd.org> <CAG6CVpWxxUuT13NL%2B0LbEDW3N91i4-imsXUBrv1jiTcihs25KQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--sgncchjjlsrijyau Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 15, 2017 at 07:38:13PM -0800, Conrad Meyer wrote: > Please revert this change. >=20 > First, it introduces the POLA-violating behavior that zstdcat deletes > its source files. This is not how zcat/bzcat behaves. This is not a POLA-violating behavior, this is a bug! that I introduced. >=20 > Second, it introduces a needless behavioral difference between FreeBSD > zstd and the rest of the world's zstd. The zstd documentation we ship > continues to claim that zstd preserves source files by default, yet > this change makes that documentation exactly backwards. While we can > change FreeBSD's documentation to accommodate the change, we can't > change Google results. >=20 The difference has been made so that zstd follow by default the same behavi= our has gzip/bzip2/xz so it can be a dropped in replacement. The argument about the documentation is however a good one. Let me do first= some tests to ensure restoring the initial behaviour does not break existing usa= ge in base Best regards, Bapt --sgncchjjlsrijyau Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAloNVKwACgkQY4mL3PG3 PlqJOxAA2AXl/BmzunHf+ptGhDVz1dSLpUNatOCBfzW5cq5FOIhMXs/OLMwBF+Go tOA2HNmtXUlDfR56dIV8vger55DtO/X3cdSDxGP8h9KX6wrxxGSvLqaTcmzUcIyY rViG0rDbKT958IqrV2VdLVGOy27uch8Vv7DMJvjbYCq0RSQED9BayDbgjlhp4T3x PiRz6DctY1qsnPKRc6oOG6L2Tj8C/VhwLos7e6CZES/P7uwZrbW+lC4mRu1t4ktl Y3yTrYw+bl8vh9XLHUnYQKGwQpr0ynJ5wSYyNjeTLSc3ZP60nVG+HMhQ5EkJXq96 0DiM+gNSHVDkmTTfycB9DGEXO8a8vV+6ZP9dcL1grE7BYdSsPtmL2gRIZKeDwttA YfyZKkathq51ei+ID1TujRaK+IKIwoxCFnvGvA6c5+wdJCn/ufTRDCJ3VlOBoa9F vcdZNEdYW9E39sMT6ilEsXtP3/zWKway2+X6VcmC/f6fBBj7rdeAhFnOcVKxqruI Avzb4Tx3EKgo0rUa0tyaSVJ2fxz1KcyOUqajNVrrzkOa+Eef4LYaDb/h/mf6a0a6 XO3rqP/pln2wfCJf4jYwo7FG5YoiKBVDvRAAKAF9k0FiBax/dPYVNs4/VqqZGawj KwHiM0fOrVsobSIy6aMvV5Uwjz6hSEBlBFpwNgXE4JpZC1wRdAA= =+P0A -----END PGP SIGNATURE----- --sgncchjjlsrijyau--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171116090447.sjwtzrwgyuarh7kv>