From owner-freebsd-python@freebsd.org Mon Jul 1 07:09:31 2019 Return-Path: Delivered-To: freebsd-python@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4434215D2158 for ; Mon, 1 Jul 2019 07:09:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id F1FAE97A2C for ; Mon, 1 Jul 2019 07:09:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id ACDEA15D2153; Mon, 1 Jul 2019 07:09:30 +0000 (UTC) Delivered-To: python@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9B4B815D2152 for ; Mon, 1 Jul 2019 07:09:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 395D897A22 for ; Mon, 1 Jul 2019 07:09:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 6AB4517611 for ; Mon, 1 Jul 2019 07:09:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x6179T8O047122 for ; Mon, 1 Jul 2019 07:09:29 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x6179T29047121 for python@FreeBSD.org; Mon, 1 Jul 2019 07:09:29 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 238821] lang/python35: Use -std=c99 Date: Mon, 01 Jul 2019 07:09:29 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: pkubaj@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ merge-quarterly? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jul 2019 07:09:31 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238821 --- Comment #20 from commit-hook@freebsd.org --- A commit references this bug: Author: koobs Date: Mon Jul 1 07:08:36 UTC 2019 New revision: 505546 URL: https://svnweb.freebsd.org/changeset/ports/505546 Log: MFH: r505210 lang/python35: Use -std=3Dc99 Python 3.5 is currently failing to build the pickle module on GCC-based architectures, with the following (several) errors: error: 'for' loop initial declaration used outside C99 mode This causes packaging to fail, as the pickle module filename changes on failure to build, so the plist ends up incorrect Python 3.6+ switched to using -std=3Dc99 [1][2], but the changes were not backported to 3.5 [1] https://bugs.python.org/issue28017 [2] https://hg.python.org/cpython/rev/b5b2bb56d303 [3] https://hg.python.org/cpython/rev/91017e2202ae PR: 238821 Reviewed by: koobs (python) Approved by: koobs (python), mat (mentor) Differential Revision: https://reviews.freebsd.org/D20778 Approved by: ports-secteam (blanket: build fix) Changes: _U branches/2019Q2/ branches/2019Q2/lang/python35/Makefile --=20 You are receiving this mail because: You are on the CC list for the bug.=