From owner-cvs-src@FreeBSD.ORG Sun Feb 3 04:43:29 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A6DC016A419; Sun, 3 Feb 2008 04:43:29 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 86E8013C44B; Sun, 3 Feb 2008 04:43:29 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 72EA01A4D82; Sat, 2 Feb 2008 20:43:29 -0800 (PST) Date: Sat, 2 Feb 2008 20:43:29 -0800 From: Alfred Perlstein To: Poul-Henning Kamp Message-ID: <20080203044329.GA99258@elvis.mu.org> References: <200802011936.m11JaR2n084955@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200802011936.m11JaR2n084955@repoman.freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man9 mbuf.9 src/sys/compat/ndis kern_ndis.c src/sys/dev/cxgb cxgb_sge.c src/sys/dev/cxgb/ulp/tom cxgb_cpl_socket.c src/sys/dev/hatm if_hatm_intr.c src/sys/dev/iscsi/initiator isc_soc.c src/sys/dev/lge if_lge.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Feb 2008 04:43:29 -0000 * Poul-Henning Kamp [080201 11:36] wrote: > phk 2008-02-01 19:36:27 UTC > > FreeBSD src repository > > Modified files: > sys/pci if_wb.c > sys/sys mbuf.h param.h > Log: > Give MEXTADD() another argument to make both void pointers to the > free function controlable, instead of passing the KVA of the buffer > storage as the first argument. > > Fix all conventional users of the API to pass the KVA of the buffer > as the first argument, to make this a no-op commit. > > Likely break the only non-convetional user of the API, after informing > the relevant committer. Informing all committers is better, this prevents people from upgrading a box and getting a dead system due to your incompatible change. Please explain exactly what has been broken. -Alfred