From owner-svn-src-head@freebsd.org Fri Jan 18 00:12:36 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E3257148533F for ; Fri, 18 Jan 2019 00:12:35 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: from mail-it1-x129.google.com (mail-it1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7E6E98C8FF for ; Fri, 18 Jan 2019 00:12:35 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: by mail-it1-x129.google.com with SMTP id i145so4345637ita.4 for ; Thu, 17 Jan 2019 16:12:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kev009.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R2ek3BtAJjNbrFlYaNXLeYo/CdRPnLa8OPk9Wpgm/Uo=; b=NBzngUZ81IGJ1uz5QtdN3p0wHb4vo1+I4DjLj3+aHqJ0uh02NyLtOs1KpLgShVy/80 hvdXvtOrjM1uC8a6UHmsLGxvRna13URNNn8EQ+12OUce1Z7h4+pEF24Rv5u2T3tS1Hl5 IE3lV0LQ6d1zsKngK82MJQBdbpgmpUtcei8ww= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R2ek3BtAJjNbrFlYaNXLeYo/CdRPnLa8OPk9Wpgm/Uo=; b=unAHs4PmEbfR4hkSORza26fasB50kFYNqerDCZ6xIwF7Qd0irfkAWAY50pdGkycAT5 lcoksG2o3//fyXFqiUfh4oIWsWZqF+LZvyaC3AEawN6YjgHFCylqYtYQvKtrSMJ0Acuj ZFtApwtmmZ0EYE0NrPGgpLuwoMjuTwpi8opN5vuEMAa9Xy0K+Ra7nGUF2AOOBrSHT0EJ C1PRzfD+n8i0yWcnQX+YcQ1yNdA2nRZy8OoxOWwwZ2MTmuuDLJldqRzqmGNqwkA3WG8B ymcJXBk/iUTnmrA7ysQMokaoUuftp1OUIt0Vld80ieOVdiny+hk+vQv7wuUtJpCDSlzx LI0A== X-Gm-Message-State: AJcUukdHaabX0WJ8LuCkz3tmiGL61G+IwvhPH0K1NDJxQ0JX0LT0IhfM EOapQKL+2sXeaergnKrLUJHIEvXLrAkq+uvwpWQKhw== X-Google-Smtp-Source: ALg8bN7zlzj8rFyig/DyECqHBSj5op07xpOIrqRFKZ1TCV/0f6JX2db4dAaoqgb/S41X116cmfMkHkShFbpw8bqY65c= X-Received: by 2002:a02:f42:: with SMTP id h63mr9500495jad.133.1547770354652; Thu, 17 Jan 2019 16:12:34 -0800 (PST) MIME-Version: 1.0 References: <201901172321.x0HNL2f4036088@repo.freebsd.org> In-Reply-To: <201901172321.x0HNL2f4036088@repo.freebsd.org> From: Kevin Bowling Date: Thu, 17 Jan 2019 17:12:23 -0700 Message-ID: Subject: Re: svn commit: r343125 - head/sys/dev/ioat To: Conrad Meyer Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 7E6E98C8FF X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.967,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jan 2019 00:12:36 -0000 Out of curiosity are you using this driver? Any performance data? On Thu, Jan 17, 2019 at 4:21 PM Conrad Meyer wrote: > Author: cem > Date: Thu Jan 17 23:21:02 2019 > New Revision: 343125 > URL: https://svnweb.freebsd.org/changeset/base/343125 > > Log: > ioat(4): Set __result_use_check on ioat_acquire_reserve > > Even M_WAITOK callers must check for failure. For example, if the > device is > quiescing, either due to automatic error-recovery induced reset, or due > to > administrative detach, the routine will return ENXIO and the acquire > reference will not be held. So, there is no mode in which it is safe to > assume the routine succeeds without checking. > > Sponsored by: Dell EMC Isilon > > Modified: > head/sys/dev/ioat/ioat.h > > Modified: head/sys/dev/ioat/ioat.h > > ============================================================================== > --- head/sys/dev/ioat/ioat.h Thu Jan 17 22:00:02 2019 (r343124) > +++ head/sys/dev/ioat/ioat.h Thu Jan 17 23:21:02 2019 (r343125) > @@ -173,7 +173,8 @@ void ioat_release(bus_dmaengine_t dmaengine); > * > * On failure, the caller does not hold the dmaengine. > */ > -int ioat_acquire_reserve(bus_dmaengine_t dmaengine, unsigned n, int > mflags); > +int ioat_acquire_reserve(bus_dmaengine_t dmaengine, unsigned n, int > mflags) > + __result_use_check; > > /* > * Issue a blockfill operation. The 64-bit pattern 'fillpattern' is > written to > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >