From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Dec 18 17:30:12 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5A4C51065675 for ; Sun, 18 Dec 2011 17:30:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 35D308FC15 for ; Sun, 18 Dec 2011 17:30:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pBIHUCLP099207 for ; Sun, 18 Dec 2011 17:30:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pBIHUCOm099204; Sun, 18 Dec 2011 17:30:12 GMT (envelope-from gnats) Resent-Date: Sun, 18 Dec 2011 17:30:12 GMT Resent-Message-Id: <201112181730.pBIHUCOm099204@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Thomas Zander Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AEC031065670 for ; Sun, 18 Dec 2011 17:30:05 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 923478FC12 for ; Sun, 18 Dec 2011 17:30:05 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pBIHU5eV050828 for ; Sun, 18 Dec 2011 17:30:05 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id pBIHU5i2050827; Sun, 18 Dec 2011 17:30:05 GMT (envelope-from nobody) Message-Id: <201112181730.pBIHU5i2050827@red.freebsd.org> Date: Sun, 18 Dec 2011 17:30:05 GMT From: Thomas Zander To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/163434: xfce4-utils dependency on xlockmore is superfluous X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Dec 2011 17:30:12 -0000 >Number: 163434 >Category: ports >Synopsis: xfce4-utils dependency on xlockmore is superfluous >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Sun Dec 18 17:30:11 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Thomas Zander >Release: >Organization: >Environment: >Description: A recent update to the xfce4-utils port to xfce4-utils-4.8.3_1 introduced a runtime dependency on x11/xlockmore, presumably to support the 'lock screen' function. However, this is not necessary since 'lock screen' also works fine if xscreensaver is installed. >How-To-Repeat: >Fix: Attached patch makes the dependency optional and lets the user choose whether the run dependency should be enforced or not. Please consider this solution for the benefit of users trying to avoid superfluous dependencies on their machines. Patch attached with submission follows: diff -ruN /usr/ports/sysutils/xfce4-utils/Makefile xfce4-utils/Makefile --- /usr/ports/sysutils/xfce4-utils/Makefile 2011-12-11 13:56:18.000000000 +0100 +++ xfce4-utils/Makefile 2011-12-18 13:33:14.965215652 +0100 @@ -7,7 +7,7 @@ PORTNAME= xfce4-utils PORTVERSION= 4.8.3 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= sysutils xfce MASTER_SITES= ${MASTER_SITE_XFCE} MASTER_SITE_SUBDIR= src/xfce/xfce-utils/${PORTVERSION:R} @@ -19,8 +19,6 @@ BUILD_DEPENDS= p5-XML-Parser>=2.40:${PORTSDIR}/textproc/p5-XML-Parser -RUN_DEPENDS= xlock:${PORTSDIR}/x11/xlockmore - DOCSDIR= ${PREFIX}/share/doc/${PORTNAME:S/4//} CONFIGURE_ARGS+=--with-xsession-prefix=${PREFIX} \ @@ -38,7 +36,8 @@ USE_XORG= x11 OPTIONS= DBUS "Enable D-BUS support" on \ - NLS "Enable Native Language Support" on + NLS "Enable Native Language Support" on \ + XLOCK "Use xlock for 'lock screen'" off .include @@ -60,6 +59,10 @@ PLIST_SUB+= NLS="@comment " .endif +.if defined(WITH_XLOCK) +RUN_DEPENDS+= xlock:${PORTSDIR}/x11/xlockmore +.endif + post-install: @-update-desktop-database >Release-Note: >Audit-Trail: >Unformatted: