Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 12 Jan 1996 17:07:05 +0100 (MET)
From:      Matthias Schündehütte <root@mscu.snafu.de>
To:        bugs@FreeBSD.org
Subject:   <sys/mount.h>
Message-ID:  <199601121607.RAA00371@mscu.snafu.de>

next in thread | raw e-mail | index | archive | help
Hi there,

while compiling the last version of 'cnews' I got the following error:

> [...]
> cc  -O2  -I../include -c dostatfs.c
> In file included from /usr/include/sys/mount.h:41,
>                  from dostatfs.c:17:
> /usr/include/sys/ucred.h:47: `NGROUPS' undeclared here (not in a function)

it's the following version of cnews:

-rw-r--r-- root/wheel       674596 Nov 30 21:23 1995 cnews.tar.Z

I just installed FreeBSD 2.1.0 from the WalnutCreek CD-ROM. I previously
compiled just that version of cnews under 2.0.5 without such problems.

I looked at /usr/include/sys/ucred.h and found the following lines:

> [...]
> 43 struct ucred {
> 44         u_short cr_ref;                 /* reference count */
> 45         uid_t   cr_uid;                 /* effective user id */
> 46         short   cr_ngroups;             /* number of groups */
> 47         gid_t   cr_groups[NGROUPS];     /* groups */
> 48 };                       =========

and ideed, NGROUPS isn't defined, neither in ucred.h nor in mount.h. It IS
defined in <sys/syslimits.h> via <sys/params.h>.

So here's my question: Where's the bug?

Is it in <sys/mount.h> where <sys/params.h> isn't included ?
Is it in <sys/ucred.h> where <sys/params.h> isn't included ?
Is it in $CNEWSROOT/util/dostatfs.c  where <sys/params.h> isn't included ?

I don't think that cnews is buggy because it compiled under FreeBSD 2.0.5. And
I don't want to edit "/usr/include"-files - they really should be read-only.

TIA - Matthias Schuendehuette (matthias@mscu.snafu.de)

--------------------------------------------------------------------------------
Matthias Schündehütte	matthias@mscu.snafu.de
Solmsstraße 44
D-10961 Berlin
GERMANY
--------------------------------------------------------------------------------



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199601121607.RAA00371>