From owner-svn-src-head@freebsd.org  Thu Jan  5 09:46:37 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9C7A7C9ED53;
 Thu,  5 Jan 2017 09:46:37 +0000 (UTC)
 (envelope-from ngie@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 6C3FF1947;
 Thu,  5 Jan 2017 09:46:37 +0000 (UTC)
 (envelope-from ngie@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v059ka2W006666;
 Thu, 5 Jan 2017 09:46:36 GMT (envelope-from ngie@FreeBSD.org)
Received: (from ngie@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id v059kaAU006665;
 Thu, 5 Jan 2017 09:46:36 GMT (envelope-from ngie@FreeBSD.org)
Message-Id: <201701050946.v059kaAU006665@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: ngie set sender to
 ngie@FreeBSD.org using -f
From: Ngie Cooper <ngie@FreeBSD.org>
Date: Thu, 5 Jan 2017 09:46:36 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r311394 - head/contrib/bsnmp/snmp_usm
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Jan 2017 09:46:37 -0000

Author: ngie
Date: Thu Jan  5 09:46:36 2017
New Revision: 311394
URL: https://svnweb.freebsd.org/changeset/base/311394

Log:
  op_usm_users: don't deref uusers if it's NULL when SETting the value
  
  Add an XXX comment to note that the conditional seems suspect given
  how it's handled elsewhere in the SNMP_OP_SET case.
  
  MFC after:	2 weeks
  Reported by:	Coverity
  CID:		1008573

Modified:
  head/contrib/bsnmp/snmp_usm/usm_snmp.c

Modified: head/contrib/bsnmp/snmp_usm/usm_snmp.c
==============================================================================
--- head/contrib/bsnmp/snmp_usm/usm_snmp.c	Thu Jan  5 09:28:38 2017	(r311393)
+++ head/contrib/bsnmp/snmp_usm/usm_snmp.c	Thu Jan  5 09:46:36 2017	(r311394)
@@ -169,8 +169,12 @@ op_usm_users(struct snmp_context *ctx, s
 		    val->var.subs[sub - 1] != LEAF_usmUserCloneFrom)
 			return (SNMP_ERR_NOSUCHNAME);
 
+		/*
+		 * XXX (ngie): need to investigate the MIB to determine how
+		 * this is possible given some of the transitions below.
+		 */
 		if (community != COMM_INITIALIZE &&
-		    uuser->type == StorageType_readOnly)
+		    uuser != NULL && uuser->type == StorageType_readOnly)
 			return (SNMP_ERR_NOT_WRITEABLE);
 
 		switch (val->var.subs[sub - 1]) {