Date: Sun, 29 Sep 2002 16:29:15 -0700 (PDT) From: Nate Lawson <nate@root.org> To: Lars Eggert <larse@ISI.EDU> Cc: Joe Marcus Clarke <marcus@marcuscom.com>, current@FreeBSD.ORG, gnome@FreeBSD.ORG Subject: Re: sys/sys/proc.h 1.250 breaks devel/libgtop2 port Message-ID: <Pine.BSF.4.21.0209291627030.80586-100000@root.org> In-Reply-To: <3D951F2A.5020504@isi.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 27 Sep 2002, Lars Eggert wrote:
> Joe Marcus Clarke wrote:
> > On Fri, 2002-09-27 at 21:54, Lars Eggert wrote:
> >
> >>Juli Mallett wrote:
> >>
> >>>* De: Lars Eggert <larse@ISI.EDU> [ Data: 2002-09-27 ]
> >>> [ Subjecte: sys/sys/proc.h 1.250 breaks devel/libgtop2 port ]
> >>>
> >>>>commenting out p_kse in sys/sys/proc.h rev 1.250 broke the
> >>>>devel/libgtop2 port (which still uses that field in
> >>>>sysdeps/freebsd/proctime.c).
> >>>
> >>>FWIW this bit me too, and I just initialised the values to zero and wrote
> >>>myself a note to note it to gnome@, and then lost the note.
> >>
> >>That's the stopgap I settled on, too :-)
> >>
> >>Now the build hangs because of sys/vnode.h rev 1.208, which removed
> >>VT_UFS...
> >
> >
> > Yep, I have a fix for this, too. You can change the == to a call to
> > strcmp, and basically do a :
> >
> > strcmp("ufs", variable) == 0;
> >
> > Like I said, I'm on vacation, or I'd have the actual patch to give to
> > you.
>
> No problem, that workaround is easy enough to apply. Thanks!
>
> Lars
> --
> Lars Eggert <larse@isi.edu> USC Information Sciences Institute
It's not a workaround, it's an outright fix. vnode->v_tag is now const
char * and that's the proper way to check for a fs type FROM USER MODE
(just making sure people note that :)
To get an idea how this works, grep getnewvnode in the sys/fs/* sources.
-Nate
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-gnome" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0209291627030.80586-100000>