Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 14 Jul 2019 05:37:43 +0200
From:      Jan Beich <jbeich@FreeBSD.org>
To:        Mark Linimon <linimon@lonesome.com>
Cc:        Mark Linimon <linimon@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r506432 - in head: audio/libcoverart audio/nekobi-lv2 benchmarks/netperfmeter chinese/pyzy comms/ncid databases/postgis25 games/diaspora graphics/gimmage graphics/pcl-pointclouds graphi...
Message-ID:  <lfx1-8ewo-wny@FreeBSD.org>
In-Reply-To: <20190714031212.GB18049@lonesome.com> (Mark Linimon's message of "Sun, 14 Jul 2019 03:12:21 %2B0000")
References:  <201907120225.x6C2P7b4029273@repo.freebsd.org> <tvbr-hpoi-wny@FreeBSD.org> <20190714031212.GB18049@lonesome.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Mark Linimon <linimon@lonesome.com> writes:

> On Fri, Jul 12, 2019 at 05:55:41AM +0200, Jan Beich wrote:
>
>> Mark Linimon <linimon@FreeBSD.org> writes:
>> 
>> > -.if exists(/usr/lib/libstdc++.so)
>> > +
>> > +.include <bsd.port.pre.mk>
>> > +
>> > +.if ${CHOSEN_COMPILER_TYPE} == gcc
>> >  CXXFLAGS+=	-stdlib=libstdc++
>> >  .endif
>> 
>> Which version of GCC supports -stdlib= flag?
>
> Note that didn't change the line that specifies CXXFLAGS, just the test
> around it.

CHOSEN_COMPILER_TYPE is always "clang" due to USES=objc:compiler but
Clang defaults to libc++ since FreeBSD 10.0. So, your commit probably
broke libobjc2 runtime on GCC-based architectures.

// From contrib/llvm/tools/clang/lib/Driver/ToolChains/FreeBSD.cpp:
ToolChain::CXXStdlibType FreeBSD::GetDefaultCXXStdlibType() const {
  if (getTriple().getOSMajorVersion() >= 10)
    return ToolChain::CST_Libcxx;
  return ToolChain::CST_Libstdcxx;
}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?lfx1-8ewo-wny>