Date: Wed, 29 Nov 2006 10:58:04 +0000 From: Ian Dowse <iedowse@iedowse.com> To: "Daan Vreeken [PA4DAN]" <Danovitsch@vitsch.net> Cc: scottl@samsco.org, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, "M. Warner Losh" <imp@bsdimp.com> Subject: Re: cvs commit: src/sys/dev/usb usbdi.c Message-ID: <200611291058.aa80677@nowhere.iedowse.com> In-Reply-To: Your message of "Tue, 28 Nov 2006 14:53:26 %2B0100." <200611281453.26820.Danovitsch@vitsch.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200611281453.26820.Danovitsch@vitsch.net>, "Daan Vreeken [PA4DAN]" writes: >I don't believe my patch is at the right place where it's placed now. Any >ideas from someone with more bus_dma-foo and/or usb-foo are highly >appreciated :) >If more debugging information is needed, just ask. Hi Daan, Thanks for all the details - I'll try to put together a patch in the next few days that adds bus_dmamap_sync() calls whereever there are shared access ordering requirements in the host controller drivers. As Olivier mentioned, bus_dma(9) says that this should be done even for BUS_DMA_COHERENT allocations, so adding them may fix problems on other platforms too. BTW it looks like some of the packet descriptor structures in the HC drivers currently throw away their bus_dma information, since the strutures are never freed, so adding the bus_dmamap_sync() calls will involve keeping track of them now. Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200611291058.aa80677>