Date: Sun, 21 Nov 2010 12:12:08 +0100 From: Stefan Farfeleder <stefanf@FreeBSD.org> To: Bernhard Schmidt <bschmidt@FreeBSD.org> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r215612 - stable/8/sys/net80211 Message-ID: <20101121111207.GA1750@mole.fafoe.narf.at> In-Reply-To: <201011211049.oALAnfH9052005@svn.freebsd.org> References: <201011211049.oALAnfH9052005@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Nov 21, 2010 at 10:49:41AM +0000, Bernhard Schmidt wrote: > Author: bschmidt > Date: Sun Nov 21 10:49:40 2010 > New Revision: 215612 > URL: http://svn.freebsd.org/changeset/base/215612 > > Log: > Compare the address of the array, not the array. > > Committed by: rpaulo > Found with: Coverity Prevent(tm) > CID: 3690 This doesn't make sense to me. How can the address of the array member be null? Also comparing the array and comparing its address has the same effect as the array is converted to the pointer anyway in the context of the comparison. Stefan > Modified: > stable/8/sys/net80211/ieee80211_scan_sta.c > Directory Properties: > stable/8/sys/ (props changed) > stable/8/sys/amd64/include/xen/ (props changed) > stable/8/sys/cddl/contrib/opensolaris/ (props changed) > stable/8/sys/contrib/dev/acpica/ (props changed) > stable/8/sys/contrib/pf/ (props changed) > stable/8/sys/dev/xen/xenpci/ (props changed) > > Modified: stable/8/sys/net80211/ieee80211_scan_sta.c > ============================================================================== > --- stable/8/sys/net80211/ieee80211_scan_sta.c Sun Nov 21 10:45:10 2010 (r215611) > +++ stable/8/sys/net80211/ieee80211_scan_sta.c Sun Nov 21 10:49:40 2010 (r215612) > @@ -1013,7 +1013,7 @@ match_bss(struct ieee80211vap *vap, > */ > if (se->se_capinfo & (IEEE80211_CAPINFO_IBSS|IEEE80211_CAPINFO_ESS)) > fail |= MATCH_CAPINFO; > - else if (se->se_meshid == NULL) > + else if (&se->se_meshid == NULL) > fail |= MATCH_MESH_NOID; > else if (ms->ms_idlen != 0 && > match_id(se->se_meshid, ms->ms_id, ms->ms_idlen)) >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101121111207.GA1750>