From owner-cvs-ports@FreeBSD.ORG  Thu Aug 19 20:02:11 2010
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DCD151065679
	for <cvs-ports@FreeBSD.org>; Thu, 19 Aug 2010 20:02:10 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4])
	by mx1.freebsd.org (Postfix) with ESMTP id 6B9CB8FC23
	for <cvs-ports@FreeBSD.org>; Thu, 19 Aug 2010 20:02:09 +0000 (UTC)
Received: (qmail 25792 invoked by uid 399); 19 Aug 2010 20:02:08 -0000
Received: from localhost (HELO lap.dougb.net) (dougb@dougbarton.us@127.0.0.1)
	by localhost with ESMTPAM; 19 Aug 2010 20:02:08 -0000
X-Originating-IP: 127.0.0.1
X-Sender: dougb@dougbarton.us
Message-ID: <4C6D8DBF.8070308@FreeBSD.org>
Date: Thu, 19 Aug 2010 13:02:07 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US;
	rv:1.9.2.8) Gecko/20100807 Thunderbird/3.1.2
MIME-Version: 1.0
To: Baptiste Daroussin <bapt@FreeBSD.org>
References: <201008171940.o7HJebDf077588@repoman.freebsd.org>
In-Reply-To: <201008171940.o7HJebDf077588@repoman.freebsd.org>
X-Enigmail-Version: 1.1.2
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, Thomas Abthorpe <tabthorpe@freebsd.org>,
	cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/www/fcgiwrap Makefile ports/www/fcgiwrap/files
 fcgiwrap.in
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Aug 2010 20:02:11 -0000

This is a very nice looking script, well done! The only problem is that 
_flags should not be added to command_args, it will cause them to be 
added twice since rc.subr already takes care of this.


Doug


On 08/17/2010 12:40, Baptiste Daroussin wrote:
> bapt        2010-08-17 19:40:37 UTC
>
>    FreeBSD ports repository
>
>    Modified files:
>      www/fcgiwrap         Makefile
>    Added files:
>      www/fcgiwrap/files   fcgiwrap.in
>    Log:
>    - Add rc script
>
>    Approved by:    tabthorpe (mentor)
>
>    Revision  Changes    Path
>    1.3       +3 -0      ports/www/fcgiwrap/Makefile
>    1.1       +75 -0     ports/www/fcgiwrap/files/fcgiwrap.in (new)
>
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/fcgiwrap/Makefile.diff?&r1=1.2&r2=1.3&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/fcgiwrap/files/fcgiwrap.in
>



-- 

	Improve the effectiveness of your Internet presence with
	a domain name makeover!    http://SupersetSolutions.com/

	Computers are useless. They can only give you answers.
			-- Pablo Picasso