Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 15 Feb 2009 13:22:22 +0000 (UTC)
From:      Ulf Lilleengen <lulf@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r188644 - head/contrib/csup
Message-ID:  <200902151322.n1FDMMYt079751@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: lulf
Date: Sun Feb 15 13:22:21 2009
New Revision: 188644
URL: http://svn.freebsd.org/changeset/base/188644

Log:
  - Do not free the pattern lists immediately after use, as they might be needed
    again in case the connection is interrupted and csup have to reconnect. The
    lists will be freed after the collection has been completely processed.
  
  PR:		bin/131477
  Tested by:	dchagin

Modified:
  head/contrib/csup/proto.c

Modified: head/contrib/csup/proto.c
==============================================================================
--- head/contrib/csup/proto.c	Sun Feb 15 12:10:05 2009	(r188643)
+++ head/contrib/csup/proto.c	Sun Feb 15 13:22:21 2009	(r188644)
@@ -521,12 +521,6 @@ proto_xchgcoll(struct config *config)
 		coll->co_filefilter = globtree_and(fileaccept,
 		    globtree_not(filerefuse));
 
-		/* At this point we don't need the pattern lists anymore. */
-		pattlist_free(coll->co_accepts);
-		pattlist_free(coll->co_refusals);
-		coll->co_accepts = NULL;
-		coll->co_refusals = NULL;
-
 		/* Set up a mask of file attributes that we don't want to sync
 		   with the server. */
 		if (!(coll->co_options & CO_SETOWNER))



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200902151322.n1FDMMYt079751>