From owner-svn-src-head@FreeBSD.ORG Fri Oct 24 16:33:36 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8702E1065671; Fri, 24 Oct 2008 16:33:36 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id 5698B8FC1A; Fri, 24 Oct 2008 16:33:36 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id m9OGXYZh004530 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 24 Oct 2008 09:33:34 -0700 (PDT) (envelope-from sam@freebsd.org) Message-ID: <4901F8DE.9050803@freebsd.org> Date: Fri, 24 Oct 2008 09:33:34 -0700 From: Sam Leffler Organization: FreeBSD Project User-Agent: Thunderbird 2.0.0.9 (X11/20071125) MIME-Version: 1.0 To: Marcel Moolenaar References: <200810230151.m9N1ptUe044619@svn.freebsd.org> <20081023.190942.74668946.imp@bsdimp.com> <4901F173.2070701@freebsd.org> <37EC82F7-ECD8-4470-8406-084D7F839664@mac.com> <4901F46D.8010906@freebsd.org> <5D27204C-0E14-4154-BBC5-AB90B1AC657D@mac.com> In-Reply-To: <5D27204C-0E14-4154-BBC5-AB90B1AC657D@mac.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC--Metrics: ebb.errno.com; whitelist Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Warner Losh Subject: Re: svn commit: r184193 - in head/sys: arm/conf conf X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Oct 2008 16:33:36 -0000 Marcel Moolenaar wrote: > > On Oct 24, 2008, at 9:14 AM, Sam Leffler wrote: > >>>> This is just wrong and clearly Marvel never discussed it with >>>> anyone working on arm systems or he'd have gotten an earful. >>> >>> Get your facts straight. >>> >> I checked with folks and you never asked for review of this change. > > What you mean to say is: "Oops, sorry!" So long as "you" == marcel that is correct. I don't know if it's the phase of the moon but we seem to have a spate of commits that affect many folks but were not peer-reviewed. This is bad for the health of the project and I will complain when I see it happen. > >> As to not changing behaviour; the existing use of mbr+bsdlabels is >> stopgap and I believe everyone actively working on these platforms >> would like to ditch 'em. > > I am actively working on ARM and I need to ditch them myself. > For that I chose to make them optional first so that people > can keep the old behaviour if they want to. Stopgap or not, > as ARM was before my change, those two were non-optional. > Glad to hear you're working on ARM. Please talk to others actively involved so we can share the work. Sam