Date: Tue, 10 Jan 2012 10:38:28 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Eitan Adler <eadler@FreeBSD.org> Subject: Re: svn commit: r229908 - head/usr.bin/brandelf Message-ID: <4F0C0714.6060501@FreeBSD.org> In-Reply-To: <20120110082106.GD1801@garage.freebsd.pl> References: <201201100258.q0A2wT7E079753@svn.freebsd.org> <20120110082106.GD1801@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2012-01-10 09:21, Pawel Jakub Dawidek wrote: > On Tue, Jan 10, 2012 at 02:58:29AM +0000, Eitan Adler wrote: >> Author: eadler (ports committer) >> Date: Tue Jan 10 02:58:29 2012 >> New Revision: 229908 >> URL: http://svn.freebsd.org/changeset/base/229908 >> >> Log: >> Fix warning when compiling with gcc46: >> error: variable 'verbose' set but not use > > Maybe we should remove -v from the manual page as well or document as no-op? > I'd still leave it in the code though, so there is no POLA violation. It has been a no-op since the beginning of brandelf, and I have really no idea what the original author intended the verbose output to be. :) It is probably best to document it as a no-op now, to reduce possible confusion.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F0C0714.6060501>