From owner-cvs-src@FreeBSD.ORG Sat Oct 8 20:04:28 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7177D16A421; Sat, 8 Oct 2005 20:04:28 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 41CDE43D45; Sat, 8 Oct 2005 20:04:28 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j98K4SNi097158; Sat, 8 Oct 2005 20:04:28 GMT (envelope-from truckman@repoman.freebsd.org) Received: (from truckman@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j98K4S2L097157; Sat, 8 Oct 2005 20:04:28 GMT (envelope-from truckman) Message-Id: <200510082004.j98K4S2L097157@repoman.freebsd.org> From: Don Lewis Date: Sat, 8 Oct 2005 20:04:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/ufs/ffs ffs_alloc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Oct 2005 20:04:28 -0000 truckman 2005-10-08 20:04:28 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/ufs/ffs ffs_alloc.c Log: MFC ffs_alloc.c 1.135 - clear i_flag field in recycled inodes The IN_HASHED bit should not be cleared here in RELENG_5. Original commit message: truckman 2005-10-03 21:57:43 UTC FreeBSD src repository Modified files: sys/ufs/ffs ffs_alloc.c Log: Initialize the inode i_flag field in ffs_valloc() to clean up any stale flag bits left over from before the inode was recycled. Without this change, a leftover IN_SPACECOUNTED flag could prevent softdep_freefile() and softdep_releasefile() from incrementing fs_pendinginodes. Because handle_workitem_freefile() unconditionally decrements fs_pendinginodes, a negative value could be reported at file system unmount time with a message like: unmount pending error: blocks 0 files -3 The pending block count in fs_pendingblocks could also be negative for similar reasons. These errors can cause the data returned by statfs() to be slightly incorrect. Some other cleanup code in softdep_releasefile() could also be incorrectly bypassed. MFC after: 3 days Revision Changes Path 1.135 +1 -0 src/sys/ufs/ffs/ffs_alloc.c Revision Changes Path 1.123.2.5 +1 -0 src/sys/ufs/ffs/ffs_alloc.c