Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 5 Jul 2011 14:13:34 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Martin Wilke <miwi@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/devel Makefile ports/devel/libestr Makefile distinfo pkg-descr pkg-plist ports/devel/libestr/files patch-Makefile.in
Message-ID:  <20110705141333.GA23300@FreeBSD.org>
In-Reply-To: <201106271435.p5REZYab035297@repoman.freebsd.org>
References:  <201106271435.p5REZYab035297@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 27, 2011 at 02:35:34PM +0000, Martin Wilke wrote:
> miwi        2011-06-27 14:35:34 UTC
> 
>   Modified files:
>     devel                Makefile 
>   Added files:
>     devel/libestr        Makefile distinfo pkg-descr pkg-plist 
>     devel/libestr/files  patch-Makefile.in 
>   Log:
>   A library for some string essentials.

This description (= pkg-descr) is very short and uninformative.  Also, the
port has other issues:

- Does pgollucci@ know and approve that he's listed as maintainer?
- Bogus CONFIGURE_ARGS indentation; also --prefix="${PREFIX}" is redundant
  since GNU_CONFIGURE is used
- Tab instead of space after WWW: line in pkg-descr

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110705141333.GA23300>