From owner-cvs-src@FreeBSD.ORG Sat Mar 17 19:09:24 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6F73816A408; Sat, 17 Mar 2007 19:09:24 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from webaccess-cl.virtdom.com (webaccess-cl.virtdom.com [216.240.101.25]) by mx1.freebsd.org (Postfix) with ESMTP id 121E113C4D5; Sat, 17 Mar 2007 19:09:23 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from [10.0.0.1] (63-226-247-187.tukw.qwest.net [63.226.247.187]) (authenticated bits=0) by webaccess-cl.virtdom.com (8.13.6/8.13.6) with ESMTP id l2HJ9Lmo081798 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO); Sat, 17 Mar 2007 14:09:22 -0500 (EST) (envelope-from jroberson@chesapeake.net) Date: Sat, 17 Mar 2007 11:09:11 -0800 (PST) From: Jeff Roberson X-X-Sender: jroberson@10.0.0.1 To: Jeff Roberson In-Reply-To: <200703171813.l2HIDXWI008212@repoman.freebsd.org> Message-ID: <20070317110821.I560@10.0.0.1> References: <200703171813.l2HIDXWI008212@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Mar 2007 19:09:24 -0000 Any language lawyers care to comment on this? On Sat, 17 Mar 2007, Jeff Roberson wrote: > jeff 2007-03-17 18:13:33 UTC > > FreeBSD src repository > > Modified files: > sys/kern sched_ule.c > Log: > - Cast the intermediate value in priority computtion back down to > unsigned char. Weirdly, casting the 1 constant to u_char still produces > a signed integer result that is then used in the % computation. This > avoids that mess all together and causes a 0 pri to turn into 255 % 64 > as we expect. > > Reported by: kkenn (about 4 times, thanks) > > Revision Changes Path > 1.190 +1 -1 src/sys/kern/sched_ule.c >