Date: Wed, 27 Dec 2006 16:20:24 GMT From: Kostik Belousov <kostikbel@gmail.com> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/92785: Using exported filesystem on OS/2 NFS client causes filesystem freeze Message-ID: <200612271620.kBRGKOrM057746@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/92785; it has been noted by GNATS. From: Kostik Belousov <kostikbel@gmail.com> To: Ulrich Spoerlein <uspoerlein@gmail.com> Cc: bug-followup@freebsd.org, Bruce Evans <bde@zeta.org.au> Subject: Re: kern/92785: Using exported filesystem on OS/2 NFS client causes filesystem freeze Date: Wed, 27 Dec 2006 18:17:07 +0200 --1Dvf9Qz7hFaodvwE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 27, 2006 at 05:05:00PM +0100, Ulrich Spoerlein wrote: > Attached is the cumulative diff of the kernel I tested this with. > Tested filesystems needing patch: ufs, msdosfs, cd9660, ext2fs > Tested filesystems sans patch: reiserfs > Untested filesystems: udf, ntfs, smbfs, nwfs, (zfs?) The better change for UDF: Index: fs/udf/udf_vnops.c =================================================================== RCS file: /usr/local/arch/ncvs/src/sys/fs/udf/udf_vnops.c,v retrieving revision 1.61 diff -u -r1.61 udf_vnops.c --- fs/udf/udf_vnops.c 3 Feb 2006 15:25:52 -0000 1.61 +++ fs/udf/udf_vnops.c 27 Dec 2006 16:16:51 -0000 @@ -915,7 +915,7 @@ if (flags & ISDOTDOT) VOP_UNLOCK(dvp, 0, a->a_cnp->cn_thread); error = udf_vget(udfmp->im_mountp, id, LK_EXCLUSIVE, &tdp); - if (flags & ISDOTDOT) + if ((flags & ISDOTDOT) && (dvp != tdp || error)) vn_lock(dvp, LK_EXCLUSIVE|LK_RETRY, a->a_cnp->cn_thread); if (!error) { /* --1Dvf9Qz7hFaodvwE Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFFkpyDC3+MBN1Mb4gRAvrRAJ9gle9FlZjtWW/HwO7B+/H0D9prKQCgknms p+CM6dkPOX7AF8Aq0aOhZOQ= =1sbA -----END PGP SIGNATURE----- --1Dvf9Qz7hFaodvwE--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200612271620.kBRGKOrM057746>