From owner-cvs-all@FreeBSD.ORG Tue Sep 19 19:36:42 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B672F16A415 for ; Tue, 19 Sep 2006 19:36:42 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.224]) by mx1.FreeBSD.org (Postfix) with ESMTP id A6EF143D45 for ; Tue, 19 Sep 2006 19:36:41 +0000 (GMT) (envelope-from maksim.yevmenkin@gmail.com) Received: by wx-out-0506.google.com with SMTP id i27so4434191wxd for ; Tue, 19 Sep 2006 12:36:39 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=uq8/JBQDiXVH2AUSGvoPa7Yo7/JsB1kWwPY5GoDkZd8TDcex0ASEYEeaN90poRa+OjbXRdAK53juPtm40cq4mu5TjUcufKEZ8Gq61PCrNkg+RyrtqFQ5yjc2i/6DSSDJfk6iZKX+YjIadtjyT5LAY/FUij6JoDG4wLEyqbsTk2Y= Received: by 10.70.83.4 with SMTP id g4mr22941157wxb; Tue, 19 Sep 2006 12:36:38 -0700 (PDT) Received: by 10.70.55.2 with HTTP; Tue, 19 Sep 2006 12:36:38 -0700 (PDT) Message-ID: Date: Tue, 19 Sep 2006 12:36:38 -0700 From: "Maksim Yevmenkin" To: "Ruslan Ermilov" In-Reply-To: <20060919190645.GA23068@rambler-co.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200609191303.k8JD3AHl050783@repoman.freebsd.org> <20060919190645.GA23068@rambler-co.ru> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/kbdmux kbdmux.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2006 19:36:42 -0000 Ruslan, > > revision 1.12 does NOT work on sparc64. it causes crash with > > > > panic: trap: memory address not aligned > > > I was affraid of something like this, but given that an argument > is 64-bit aligned, I didn't think it would be a real problem. > Can you try removing the (int) casts in front of *(intptr_t *) > and see if it helps? nope, same crash. the only thing that seems to help is to reverting back to (int *) cast just like other keyboard drivers do. then it works. i'm in the process of getting amd64 snapshot iso to try it on a couple of boxes. if it will work then i'm going to back (int *) -> (intptr_t *) changes introduced in rev 1.8. thanks, max > > > i'll try to find which particular ioctl causes it. in the mean time > > reverting everything back to (int *) casting makes everything work. > > > > btw, other keyboard drivers ukbd(4), atkbd(4) and sunkbd(4) use simple > > cast (int *) and NOT intptr_t. > > > > thanks, > > max > > > > On 9/19/06, Ruslan Ermilov wrote: > > >ru 2006-09-19 13:03:10 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/dev/kbdmux kbdmux.c > > > Log: > > > Make typecast expressions comply with style(9). > > > > > > Revision Changes Path > > > 1.12 +5 -5 src/sys/dev/kbdmux/kbdmux.c > > > Cheers, > -- > Ruslan Ermilov > ru@FreeBSD.org > FreeBSD committer > > >