From owner-cvs-src@FreeBSD.ORG Fri Nov 12 09:27:59 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5BD8D16A4D0; Fri, 12 Nov 2004 09:27:59 +0000 (GMT) Received: from kane.otenet.gr (kane.otenet.gr [195.170.0.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 855B943D3F; Fri, 12 Nov 2004 09:27:56 +0000 (GMT) (envelope-from keramida@ceid.upatras.gr) Received: from orion.daedalusnetworks.priv (aris.bedc.ondsl.gr [62.103.39.226])iAC9RpcU020990; Fri, 12 Nov 2004 11:27:55 +0200 Received: from orion.daedalusnetworks.priv (orion [127.0.0.1]) iAC9RpvL001442; Fri, 12 Nov 2004 11:27:51 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Received: (from keramida@localhost)iAC9RpZV001441; Fri, 12 Nov 2004 11:27:51 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Date: Fri, 12 Nov 2004 11:27:51 +0200 From: Giorgos Keramidas To: Ian Dowse Message-ID: <20041112092751.GF671@orion.daedalusnetworks.priv> References: <200411120257.iAC2vZp2063849@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200411120257.iAC2vZp2063849@repoman.freebsd.org> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb ehci.c ohci.c uhci.c usb_port.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Nov 2004 09:27:59 -0000 On 2004-11-12 02:57, Ian Dowse wrote: > iedowse 2004-11-12 02:57:35 UTC > > FreeBSD src repository > > Modified files: > sys/dev/usb ehci.c ohci.c uhci.c usb_port.h > Log: > Back out my recent changes for timeout races, as there have been > reports of problems. The bug is probably that there are cases where > `xfer->timeout && !sc->sc_bus.use_polling' is not a suitable test > for an active timeout callout, so an explicit flag will be necessary. > Apologies for the breakage. No apologies needed. This is CURRENT ;-) I had a very "interesting" afternoon. Very much in the sense of "interesting" defined in "Interesting Times" by Terry Pratchett ;-)