Date: Wed, 14 Oct 2015 18:30:43 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Kristof Provost <kp@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r289316 - in head/sys: net netpfil/pf Message-ID: <20151014163043.GJ55137@ivaldir.etoilebsd.net> In-Reply-To: <201510141621.t9EGLfas015240@repo.freebsd.org> References: <201510141621.t9EGLfas015240@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--enLffk0M6cffIOOh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 14, 2015 at 04:21:41PM +0000, Kristof Provost wrote: > Author: kp > Date: Wed Oct 14 16:21:41 2015 > New Revision: 289316 > URL: https://svnweb.freebsd.org/changeset/base/289316 >=20 > Log: > pf: Fix TSO issues > =20 > In certain configurations (mostly but not exclusively as a VM on Xen) pf > produced packets with an invalid TCP checksum. > =20 > The problem was that pf could only handle packets with a full checksum.= The > FreeBSD IP stack produces TCP packets with a pseudo-header checksum (on= ly > addresses, length and protocol). > Certain network interfaces expect to see the pseudo-header checksum, so= they > end up producing packets with invalid checksums. > =20 > To fix this stop calculating the full checksum and teach pf to only upd= ate TCP > checksums if TSO is disabled or the change affects the pseudo-header ch= ecksum. > =20 > PR: 154428, 193579, 198868 > Reviewed by: sbruno > MFC after: 1 week > Relnotes: yes > Sponsored by: RootBSD > Differential Revision: https://reviews.freebsd.org/D3779 >=20 Excellent! do you think it would be possible to get an errata on 10.2? that would be useful for every instance of freebsd running on cloudish stuff! Best regards, Bapt --enLffk0M6cffIOOh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlYegzMACgkQ8kTtMUmk6EzZnQCeNipmWR2fVd67kiuOI8/mAWWY TzEAn2K98Dm1KXczy2eSqDRY/ZuHRfiq =wyhp -----END PGP SIGNATURE----- --enLffk0M6cffIOOh--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151014163043.GJ55137>