Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 6 Dec 2013 10:27:09 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        Kevin Lo <kevlo@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r259031 - head/sys/dev/usb/wlan
Message-ID:  <201312061027.09144.jhb@freebsd.org>
In-Reply-To: <201312061517.rB6FHTOa007535@svn.freebsd.org>
References:  <201312061517.rB6FHTOa007535@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, December 06, 2013 10:17:29 am Kevin Lo wrote:
> Author: kevlo
> Date: Fri Dec  6 15:17:28 2013
> New Revision: 259031
> URL: http://svnweb.freebsd.org/changeset/base/259031
> 
> Log:
>   Replace the magic numbers with something more readable.
> 
> Modified:
>   head/sys/dev/usb/wlan/if_run.c
>   head/sys/dev/usb/wlan/if_runreg.h
> 
> Modified: head/sys/dev/usb/wlan/if_run.c
> 
==============================================================================
> --- head/sys/dev/usb/wlan/if_run.c	Fri Dec  6 15:15:58 2013	(r259030)
> +++ head/sys/dev/usb/wlan/if_run.c	Fri Dec  6 15:17:28 2013	(r259031)
> @@ -4530,7 +4530,7 @@ run_rt5390_bbp_init(struct run_softc *sc
>  
>  	/* Avoid data lost and CRC error. */
>  	run_bbp_read(sc, 4, &bbp4);
> -	run_bbp_write(sc, 4, bbp4 | 0x40);
> +	run_bbp_write(sc, 4, bbp | RT5390_MAC_IF_CTRL);

The s/bbp4/bbp/ here looks like a bug?

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312061027.09144.jhb>