From owner-freebsd-current@freebsd.org Sat Aug 29 20:17:21 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 552F39C5A6B for ; Sat, 29 Aug 2015 20:17:21 +0000 (UTC) (envelope-from cvs-src@yandex.ru) Received: from forward5m.mail.yandex.net (forward5m.mail.yandex.net [IPv6:2a02:6b8:0:2519::3:14]) by mx1.freebsd.org (Postfix) with ESMTP id 094471303 for ; Sat, 29 Aug 2015 20:17:20 +0000 (UTC) (envelope-from cvs-src@yandex.ru) Received: from smtp3m.mail.yandex.net (smtp3m.mail.yandex.net [IPv6:2a02:6b8:0:2519::125]) by forward5m.mail.yandex.net (Yandex) with ESMTP id 33A3B29A06AC for ; Sat, 29 Aug 2015 23:17:12 +0300 (MSK) Received: from smtp3m.mail.yandex.net (localhost [127.0.0.1]) by smtp3m.mail.yandex.net (Yandex) with ESMTP id 06C2627A05BF for ; Sat, 29 Aug 2015 23:17:11 +0300 (MSK) Received: by smtp3m.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id TJM2FsCGnU-HB0ivZ2u; Sat, 29 Aug 2015 23:17:11 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1440879431; bh=6t/Ddqvp5Gcst+iL4WDJb896OIsRFpQygaIuhdfp65E=; h=To:From:Subject:Message-ID:Date:User-Agent:MIME-Version: Content-Type; b=HQJJnE5ArgqncEYaVhCD5H43dhppeJR0X0jofTIpJO07sd3YRgtNYSvUVrEYBwgA9 PaIUhYVM9Kju1d36o+ar/tl09E7RjKNrNtQ579r280KwPI+7th7DCZMjmCfyJzDS91 O5Ee50pSJZN+VqCt+wWjpQHLcwume6vDf/GfjGEc= Authentication-Results: smtp3m.mail.yandex.net; dkim=pass header.i=@yandex.ru X-Yandex-ForeignMX: US To: FreeBSD Current From: Ruslan Makhmatkhanov Subject: [drm:i915_gem_object_unbind] *ERROR* Attempting to unbind pinned buffer Message-ID: <55E212F9.6010908@yandex.ru> Date: Sat, 29 Aug 2015 23:15:53 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------030401020100070903020508" X-Mailman-Approved-At: Sat, 29 Aug 2015 21:31:42 +0000 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Aug 2015 20:17:21 -0000 This is a multi-part message in MIME format. --------------030401020100070903020508 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hello, I'm getting tons of this in /var/log/messages: error: [drm:pid9:i915_gem_object_unbind] *ERROR* Attempting to unbind pinned buffer As far I understand [1], this case is harmless and there is no point to print it with DRM_ERROR - DRM_DEBUG is sufficient. Can we please change it in our tree like it done in patch attached? Thanks. PS. In Linux 3.8 [2] this check was changed by removing the warning altogether and just returning -EBUSY, so may be we can do just this to reduce the diff ;). [1] https://bugs.freedesktop.org/show_bug.cgi?id=50075 [2] http://lxr.free-electrons.com/source/drivers/gpu/drm/i915/i915_gem.c?v=3.8 -- Regards, Ruslan T.O.S. Of Reality --------------030401020100070903020508 Content-Type: text/x-patch; name="i915_gem_object_unbind_silent.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="i915_gem_object_unbind_silent.diff" Index: sys/dev/drm2/i915/i915_gem.c =================================================================== --- sys/dev/drm2/i915/i915_gem.c (revision 287214) +++ sys/dev/drm2/i915/i915_gem.c (working copy) @@ -2528,7 +2528,7 @@ return 0; if (obj->pin_count) { - DRM_ERROR("Attempting to unbind pinned buffer\n"); + DRM_DEBUG("Attempting to unbind pinned buffer\n"); return -EINVAL; } --------------030401020100070903020508--