Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 27 Aug 2004 18:12:11 +0200
From:      Max Laier <max@love2party.net>
To:        Andre Oppermann <andre@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/share/man/man4 ipfirewall.4 src/share/man/man9 pfil.9 src/sys/alpha/conf GENERIC src/sys/amd64/conf GENERIC src/sys/conf NOTES files options src/sys/i386/conf GENERIC src/sys/ia64/conf GENERIC SKI src/sys/modules/bridge Makefile ...
Message-ID:  <200408271812.18748.max@love2party.net>
In-Reply-To: <200408271516.i7RFGO8L061926@repoman.freebsd.org>
References:  <200408271516.i7RFGO8L061926@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--Boundary-02=_i11LB3cInq8GUcK
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Friday 27 August 2004 17:16, Andre Oppermann wrote:
> andre       2004-08-27 15:16:24 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     share/man/man4       ipfirewall.4
>     share/man/man9       pfil.9
>     sys/alpha/conf       GENERIC
>     sys/amd64/conf       GENERIC
>     sys/conf             NOTES files options
>     sys/i386/conf        GENERIC
>     sys/ia64/conf        GENERIC SKI
>     sys/modules/bridge   Makefile
>     sys/net              bridge.c
>     sys/netinet          ip_fastfwd.c ip_fw_pfil.c ip_input.c
>                          ip_output.c ip_var.h
>     sys/netinet6         ip6_forward.c ip6_input.c ip6_output.c
>                          ip6_var.h
>     sys/pc98/conf        GENERIC
>     sys/powerpc/conf     GENERIC
>     sys/sparc64/conf     GENERIC
>     .                    UPDATING
>   Log:
>   Always compile PFIL_HOOKS into the kernel and remove the associated
> kernel compile option.  All FreeBSD packet filters now use the PFIL_HOOKS
> API and thus it becomes a standard part of the network stack.
>
>   If no hooks are connected the entire packet filter hooks section and
> related activities are jumped over.  This removes any performance impact =
if
> no hooks are active.

Great!!!

Maybe we should hide:
  if (inet_pfil_hook.ph_busy_count =3D=3D -1)
behind a macro in case we modify the locking for pfil_hooks in the future. =
I=20
am thinking of something like:
 if (PFIL_IS_EMPTY(&inet_pfil_hook))

If you agree, I can roll a diff.

=2D-=20
/"\  Best regards,                      | mlaier@freebsd.org
\ /  Max Laier                          | ICQ #67774661
 X   http://pf4freebsd.love2party.net/  | mlaier@EFnet
/ \  ASCII Ribbon Campaign              | Against HTML Mail and News

--Boundary-02=_i11LB3cInq8GUcK
Content-Type: application/pgp-signature
Content-Description: signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (FreeBSD)

iD8DBQBBL11iXyyEoT62BG0RAtgYAJ0TKHo1ESlB4cO0AHfTz/NiEkm0JACbBMza
8aBucHqCFwMRblm2JeM71lc=
=nUFp
-----END PGP SIGNATURE-----

--Boundary-02=_i11LB3cInq8GUcK--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200408271812.18748.max>