Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 28 May 2003 16:28:20 +0100
From:      David Malone <dwmalone@maths.tcd.ie>
To:        Robert Watson <rwatson@FreeBSD.org>
Cc:        current@FreeBSD.org
Subject:   Re: mb alloc and: panic: mutex Giant not owned at ../../../vm/vm_kern.c:315 
Message-ID:  <200305281628.aa67444@salmon.maths.tcd.ie>
In-Reply-To: Your message of "Wed, 28 May 2003 11:19:45 EDT." <Pine.NEB.3.96L.1030528111845.51795D-100000@fledge.watson.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
> > This may be my fault, as I made some changes recently that assumed that
> > the mbuf allocator grabbed giant when needed. I'll check the code path
> > you've mentioned to see if it grabs giant now, but I suspect that I just
> > need to move the giant grabbing back where it was before. 

> This doesn't seem to be a reproduceable problem for me, FWIW, (presumably
> a property of bucket sizes, etc) so you have all the information I have
> :-).

You'd have to be quite unlucky to trigger it (calling sendit at a
time when a per-cpu mbuf pool was empty). I have a vague feeling
that my sendit change isn't the only place that does this.

> If possible, we should get this fix in for 5.1?

Yep - from what Bosko says, my change shouldn't have been safe.
I'll produce a patch and run it by him, and then talk to re@.

	David.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200305281628.aa67444>