From owner-svn-src-all@freebsd.org Thu Jul 11 01:41:31 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 236EC15E8F19; Thu, 11 Jul 2019 01:41:31 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BB39085004; Thu, 11 Jul 2019 01:41:30 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id AD21314767; Thu, 11 Jul 2019 01:41:30 +0000 (UTC) Date: Thu, 11 Jul 2019 01:41:30 +0000 From: Alexey Dokuchaev To: Warner Losh Cc: Shawn Webb , svn-src-head , svn-src-all , src-committers , Justin Hibbits , Philip Paeps Subject: Re: svn commit: r349890 - head/contrib/telnet/telnet Message-ID: <20190711014130.GA23621@FreeBSD.org> References: <201907101742.x6AHg4os016752@repo.freebsd.org> <20190710195548.kdftfemj3icarcxo@mutt-hbsd> <20190710151944.0fd94ec3@titan.knownspace> <20190710202218.yc3lcd6tsql3zkyr@mutt-hbsd> <20190710222918.vj4creizlubdzgw3@mutt-hbsd> <20190710224341.i3rbhapmpdw6gkbd@mutt-hbsd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: BB39085004 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.90 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.90)[-0.898,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jul 2019 01:41:31 -0000 On Wed, Jul 10, 2019 at 04:45:06PM -0600, Warner Losh wrote: > On Wed, Jul 10, 2019 at 4:43 PM Shawn Webb > > ... > > Because the existing code already used malloc + snprintf. And this is > > contrib/telnet/telnet, which arguably should be `rm -rf`ed. ;) > > > > The bike shed is now glow-in-the-dark neon green. > > I'm not in the rm-rf telnet camp... I use it far too often to connect > to a port with good terminal support to want to do that... Seconded. Having telnet(1) in the base is so fucking convenient compared to GNU/Linux or Windoze where they've removed it from the default install. ./danfe