From owner-cvs-all@FreeBSD.ORG  Tue Oct 16 21:31:16 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9B44516A417;
	Tue, 16 Oct 2007 21:31:16 +0000 (UTC)
	(envelope-from doginou@dong.ci0.org)
Received: from dong.ci0.org (dong.ci0.org [IPv6:2001:7a8:2066:1::1])
	by mx1.freebsd.org (Postfix) with ESMTP id B13E513C45A;
	Tue, 16 Oct 2007 21:31:15 +0000 (UTC)
	(envelope-from doginou@dong.ci0.org)
Received: from dong.ci0.org (localhost.ci0.org [127.0.0.1])
	by dong.ci0.org (8.13.8/8.13.8) with ESMTP id l9GMJ4kj075199;
	Wed, 17 Oct 2007 00:19:04 +0200 (CEST)
	(envelope-from doginou@dong.ci0.org)
Received: (from doginou@localhost)
	by dong.ci0.org (8.14.1/8.13.8/Submit) id l9GMJ31R075198;
	Wed, 17 Oct 2007 00:19:04 +0200 (CEST) (envelope-from doginou)
Date: Wed, 17 Oct 2007 00:19:03 +0200
From: Olivier Houchard <cognet@ci0.org>
To: John Baldwin <jhb@FreeBSD.org>
Message-ID: <20071016221903.GA75176@ci0.org>
References: <200710161957.l9GJvaFr075367@repoman.freebsd.org>
	<200710161637.36950.jhb@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200710161637.36950.jhb@freebsd.org>
User-Agent: Mutt/1.4.1i
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/sys proc.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Oct 2007 21:31:16 -0000

On Tue, Oct 16, 2007 at 04:37:36PM -0400, John Baldwin wrote:
> On Tuesday 16 October 2007 03:57:36 pm Olivier Houchard wrote:
> > cognet      2007-10-16 19:57:36 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:        (Branch: RELENG_6)
> >     sys/sys              proc.h 
> >   Log:
> >   Make td_sqqueue explicitely signed, as we compare it with >= 0. On arm,
> >   char defaults to unsigned.
> 
> It probably should really be unsigned like td_tsqueue (serves the same 
> purpose) FWIW, however it is currently an 'int' in HEAD.
> 
> Probably changing td_sqqueue to u_char in HEAD, 7.x and 6.x would be the best 
> fix.

I didn't investigate much. I saw it was an int on -CURRENT, and this test :
	MPASS(td->td_sqqueue < NR_SLEEPQS && td->td_sqqueue >= 0);
If td_squeue can be unsigned, the test is wrong.

Regards, 

Olivier