Date: Wed, 03 Mar 2010 14:20:28 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: neelnatu@gmail.com Cc: mips@FreeBSD.org Subject: Re: MIPS_MEM_RID Message-ID: <20100303.142028.706189011771610223.imp@bsdimp.com> In-Reply-To: <dffe84831003031146s5f7953f2n654bbf7be7421013@mail.gmail.com> References: <20100303.053716.584432776655158376.imp@bsdimp.com> <20100303150238.68be18a3.ray@dlink.ua> <dffe84831003031146s5f7953f2n654bbf7be7421013@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <dffe84831003031146s5f7953f2n654bbf7be7421013@mail.gmail.com>
Neel Natu <neelnatu@gmail.com> writes:
: Hi Alexandr,
:
: On Wed, Mar 3, 2010 at 5:02 AM, Alexandr Rybalko <ray@dlink.ua> wrote:
: > On Wed, 03 Mar 2010 05:37:16 -0700 (MST)
: > "M. Warner Losh" <imp@bsdimp.com> wrote:
: >
: >>> In message: <20100303111405.05b3c3b3.ray@dlink.ua>
: >>> Alexandr Rybalko <ray@dlink.ua> writes:
: >>>
: >>> : Question: We really need MIPS_MEM_RID different form other
: >>> : platforms? I work on siba drivers, and we already know what siba
: >>> : can be in not MIPS device. Such as Broadcom Wi-Fi cards.
: >>>
: >>> I don't understand this question. It doesn't look like we define
: >>> MIPS_MEM_RID at all for mips. It looks to be purely an internal thing
: >>> to sys/dev/siba/siba.c.
: >>>
: >>> Warner
: >
: > I apologize for my English and for the question.
: >
: > There remained only the small tail :)
: > sys/mips/mips/nexus.c:76: #define MIPS_MEM_RID 0x20
: >
:
: Do you want to get rid of this macro from nexus.c? I don't see anybody
: using it so it should be fine.
The only place it is used is the #define here... I'm not sure why
dev/siba would need it, but even there I think it is unnecessary.c
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100303.142028.706189011771610223.imp>