Date: Tue, 29 Jan 2002 18:20:42 -0500 (EST) From: Joe Marcus Clarke <marcus@marcuscom.com> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/34429: [PATCH] Re-enable the Face browser in gdm Message-ID: <200201292320.g0TNKgj44015@shumai.marcuscom.com>
next in thread | raw e-mail | index | archive | help
>Number: 34429
>Category: ports
>Synopsis: [PATCH] Re-enable the Face browser in gdm
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Tue Jan 29 15:30:00 PST 2002
>Closed-Date:
>Last-Modified:
>Originator: Joe Marcus Clarke
>Release: FreeBSD 4.5-RC i386
>Organization:
MarcusCom, Inc.
>Environment:
System: FreeBSD shumai.marcuscom.com 4.5-RC FreeBSD 4.5-RC #0: Fri Jan 25 02:45:22 EST 2002 marcus@shumai.marcuscom.com:/usr/obj/usr/src/sys/SHUMAI i386
>Description:
For a long time now, the face browser feature in GDM hasn't worked. That is,
the icons never showed up when you enabled the face browser. This patch
re-enables that feature.
This probably should get a PORTREVISION++.
>How-To-Repeat:
Enable the face browser in gdm.conf, then restart GDM. You will notice the
login box changes, but the icons never appear.
>Fix:
--- gui/gdmlogin.c.orig Mon Dec 31 21:51:17 2001
+++ gui/gdmlogin.c Tue Jan 29 18:12:12 2002
@@ -3326,7 +3326,9 @@
static gboolean
gdm_login_check_exclude (struct passwd *pwent)
{
+#ifdef HAVE_SHADOW
const char * const lockout_passes[] = { "*", "!!", NULL };
+#endif
gint i;
if ( ! GdmAllowRoot && pwent->pw_uid == 0)
@@ -3335,11 +3337,13 @@
if ( ! GdmAllowRemoteRoot && ! login_is_local && pwent->pw_uid == 0)
return TRUE;
+#ifdef HAVE_SHADOW
for (i=0 ; lockout_passes[i] != NULL ; i++) {
if (strcmp (lockout_passes[i], pwent->pw_passwd) == 0) {
return TRUE;
}
}
+#endif
if (GdmExclude != NULL &&
GdmExclude[0] != '\0') {
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200201292320.g0TNKgj44015>