From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jun 3 15:10:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id B414CB89 for ; Mon, 3 Jun 2013 15:10:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 9AB63126A for ; Mon, 3 Jun 2013 15:10:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r53FA0i0064906 for ; Mon, 3 Jun 2013 15:10:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r53FA0tV064905; Mon, 3 Jun 2013 15:10:00 GMT (envelope-from gnats) Resent-Date: Mon, 3 Jun 2013 15:10:00 GMT Resent-Message-Id: <201306031510.r53FA0tV064905@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, John Marino Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id C3E7495F for ; Mon, 3 Jun 2013 15:05:42 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) by mx1.freebsd.org (Postfix) with ESMTP id 9C6E7120F for ; Mon, 3 Jun 2013 15:05:42 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r53F5fTT032299 for ; Mon, 3 Jun 2013 15:05:41 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r53F5fJr032169; Mon, 3 Jun 2013 15:05:41 GMT (envelope-from nobody) Message-Id: <201306031505.r53F5fJr032169@oldred.freebsd.org> Date: Mon, 3 Jun 2013 15:05:41 GMT From: John Marino To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/179261: [PATCH] devel/imake: typo fix, use shebangfix, change gcpp test X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2013 15:10:00 -0000 >Number: 179261 >Category: ports >Synopsis: [PATCH] devel/imake: typo fix, use shebangfix, change gcpp test >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jun 03 15:10:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: John Marino >Release: >Organization: >Environment: >Description: The attached patch addresses three issue: 1) error message uses backtick instead of single quote, resulting in both an unterminated quote and perhaps make may try to execute a shell command 2) This makefile uses post-patch to fix a perl shebang, use shebangfix instead 3) Instead of overriding the configure script (which may already be already redundant to Mk/bsd.port.mk lines ~1907) based on OSVERSION, actually check for the existence of /usr/bin/gcpp. (besides being a better test, it turns this test into something DragonFly can also use as OSVERSION is FreeBSD-specific) >How-To-Repeat: >Fix: Patch attached with submission follows: --- Makefile.orig 2013-06-03 14:46:00.000000000 +0000 +++ Makefile @@ -13,17 +13,19 @@ RUN_DEPENDS= gccmakedep:${PORTSDIR}/deve makedepend:${PORTSDIR}/devel/makedepend \ ${LOCALBASE}/lib/X11/config/xorg.cf:${PORTSDIR}/x11/xorg-cf-files +USES= shebangfix USE_PERL5= yes XORG_CAT= util USE_XORG= xproto +SHEBANG_FILES= mkhtmlindex.pl # clang's cpp destroys whitespace, particularly hard tabs in makefiles, # which is fatal for imake. CPPFLAGS+= -DDEFAULT_CC=\\\"gcc\\\" .ifdef USE_IMAKE -.error You have `USE_IMAKE' variable defined either in environment or in make(1) arguments. Please undefine and try again. +.error You have 'USE_IMAKE' variable defined either in environment or in make(1) arguments. Please undefine and try again. .endif MAN1= ccmakedep.1 \ @@ -37,14 +39,12 @@ MAN1= ccmakedep.1 \ xmkmf.1 post-patch: - @${PERL} -pi -e 's,^#!/usr/bin/perl,#!${PERL},' ${WRKSRC}/mkhtmlindex.pl @${REINPLACE_CMD} 's/test.*-traditional.*;/true;/' ${WRKSRC}/configure .include # Attempt to force use of GNU cpp, if it is installed as /usr/bin/gcpp. -.if (${OSVERSION} >= 900506 && ${OSVERSION} < 1000000) || \ - ${OSVERSION} >= 1000010 +.if exists(/usr/bin/gcpp) CONFIGURE_ENV+= ac_cv_path_RAWCPP="gcpp" .endif >Release-Note: >Audit-Trail: >Unformatted: