From owner-freebsd-hackers@FreeBSD.ORG  Wed Oct 27 07:33:35 2004
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D8C9816A4CE; Wed, 27 Oct 2004 07:33:35 +0000 (GMT)
Received: from cs1.cs.huji.ac.il (cs1.cs.huji.ac.il [132.65.16.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8B74343D55; Wed, 27 Oct 2004 07:33:35 +0000 (GMT)
	(envelope-from danny@cs.huji.ac.il)
Received: from pampa.cs.huji.ac.il ([132.65.80.32])
	by cs1.cs.huji.ac.il with esmtp
	id 1CMiJK-0006ZE-0v; Wed, 27 Oct 2004 09:33:34 +0200
X-Mailer: exmh version 2.7.0 06/18/2004 with nmh-1.0.4
To: bushman@rsu.ru
In-Reply-To: Message from Michael Bushkov <bushman@rsu.ru> 
	<1098785868.61417.39.camel@localhost> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Wed, 27 Oct 2004 09:33:33 +0200
From: Danny Braniss <danny@cs.huji.ac.il>
Message-Id: <20041027073335.8B74343D55@mx1.FreeBSD.org>
cc: "Jacques A. Vidrine" <nectar@freebsd.org>
cc: hackers@freebsd.org
cc: "Christian S.J. Peron" <csjp@freebsd.org>
Subject: Re: nsdispatch services patch + lookupd 
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Oct 2004 07:33:36 -0000

while trying to add hesiod/dns support, i've noticed, what looks as a problem:

in nss_tls.h, the function name##_getstate(...) can return a static pointer,
which gets freed in name##_endstate(...), as far as i know, freeing a non
malloced memory is asking for trouble.
proposed fix, instead of static, also do a calloc(...).

danny