Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 14 Sep 2019 19:19:38 +0000 (UTC)
From:      Dimitry Andric <dim@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   svn commit: r352336 - projects/clang900-import/contrib/googletest/googlemock/test
Message-ID:  <201909141919.x8EJJcrr044077@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: dim
Date: Sat Sep 14 19:19:38 2019
New Revision: 352336
URL: https://svnweb.freebsd.org/changeset/base/352336

Log:
  Work around gcc's inability to compile an incomplete type in googletest,
  leading to hundreds of lines of fairly unreadable error messages.
  
  I don't think we particularly care about the specific source file gcc
  dies on, and the many layers of macros and sub-types in googletest make
  it very hard to diagnose whether this is a bug in googletest, gcc, clang
  or libc++.

Modified:
  projects/clang900-import/contrib/googletest/googlemock/test/gmock-spec-builders_test.cc

Modified: projects/clang900-import/contrib/googletest/googlemock/test/gmock-spec-builders_test.cc
==============================================================================
--- projects/clang900-import/contrib/googletest/googlemock/test/gmock-spec-builders_test.cc	Sat Sep 14 19:16:28 2019	(r352335)
+++ projects/clang900-import/contrib/googletest/googlemock/test/gmock-spec-builders_test.cc	Sat Sep 14 19:19:38 2019	(r352336)
@@ -107,7 +107,8 @@ using testing::internal::CaptureStdout;
 using testing::internal::GetCapturedStdout;
 #endif
 
-class Incomplete;
+class Incomplete {
+};
 
 class MockIncomplete {
  public:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201909141919.x8EJJcrr044077>