From owner-freebsd-ports@FreeBSD.ORG Thu Jul 22 12:21:25 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BA9DE106566B; Thu, 22 Jul 2010 12:21:25 +0000 (UTC) (envelope-from laszlof@freebsd.org) Received: from luke.tvog.net (luke.tvog.net [66.71.253.7]) by mx1.freebsd.org (Postfix) with ESMTP id 882548FC18; Thu, 22 Jul 2010 12:21:25 +0000 (UTC) Received: from localhost.localdomain ([127.0.0.1] helo=luke.tvog.net) by luke.tvog.net with esmtpa (Exim 4.69) (envelope-from ) id 1ObuRz-0007sl-Vk; Thu, 22 Jul 2010 08:00:32 -0400 Received: from [192.168.1.2] ([127.0.0.2] helo=[192.168.1.2]) with IPv4:587 by luke.tvog.net; 22 Jul 2010 08:00:31 -0400 Message-ID: Date: Thu, 22 Jul 2010 08:00:47 -0400 From: "Frank J. Laszlo" User-Agent: Thunderbird 2.0.0.24 (Windows/20100228) MIME-Version: 1.0 To: Joe References: <4C42CFDA.3040409@comclark.com> <4C42D292.208@infracaninophile.co.uk> <4C4388D2.30200@comclark.com> <20100720190602.GA32624@server.vk2pj.dyndns.org> <4C465E14.1060300@comclark.com> In-Reply-To: <4C465E14.1060300@comclark.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Assp-ID: luke.tvog.net () X-Assp-Version: 1.7.1.3(1.0.1) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - luke.tvog.net X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - freebsd.org Cc: Doug Barton , Peter Jeremy , freebsd-ports@freebsd.org, Janne Snabb Subject: Re: [new port] usage of shar command X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jul 2010 12:21:25 -0000 Joe wrote: > The text as its currently exists is a long way from being clear to a > first timer. And I am talking about the new change that just went in. > > "shar `find port_dir` (note the backticks)", > > or > > "shar $(find port_dir)" > > both address the problem nicely. > > By all means go and make the correction. > The solution you've provided is not portable across shells. Also, I believe its safe to expect port developers to be at least somewhat familiar with shell scripting basics. There are other ways to contribute to the project that do not require such skills, but if we want to increase the overall quality of ports as well as existing PR's, we need to set some kind of standard. After all, it only wastes the time of the volunteers who commit the thousands of PRs when they receive poorly written ports, updates, etc. I'm not trying to attack the OP, but I wanted to voice my objection for dumbing down the handbook to the point that a 3 year old could figure it out. Regards, Frank Laszlo