From owner-cvs-all@FreeBSD.ORG Wed Nov 3 18:30:56 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2AE2B16A4D0 for ; Wed, 3 Nov 2004 18:30:56 +0000 (GMT) Received: from mail3.speakeasy.net (mail3.speakeasy.net [216.254.0.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id DBF7D43D4C for ; Wed, 3 Nov 2004 18:30:55 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 14107 invoked from network); 3 Nov 2004 18:30:55 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 3 Nov 2004 18:30:12 -0000 Received: from [10.50.41.235] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iA3ITuin078425; Wed, 3 Nov 2004 13:29:59 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Daniel Eischen Date: Wed, 3 Nov 2004 14:31:16 -0500 User-Agent: KMail/1.6.2 References: In-Reply-To: MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200411031431.16218.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: David Xu cc: cvs-all@FreeBSD.org cc: Julian Elischer Subject: Re: cvs commit: src/lib/libpthread/thread thr_private.h thr_sig.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 18:30:56 -0000 On Tuesday 02 November 2004 06:40 pm, Daniel Eischen wrote: > On Wed, 3 Nov 2004, David Xu wrote: > > John Baldwin wrote: > > >On Monday 01 November 2004 06:04 pm, David Xu wrote: > > >>Not every important, I think I have another very important history > > >>bug in hand, did you get my "fix famous libpthread conditional > > >>variable race condition" mail ? :-) > > > > > >Oooo, can I test it please? We are still having problems with mono on > > > HEAD here at work. I tried merging the changes in uthread_cond.c 1.32 > > > to libpthread but that seemed to make it worse. The problems seem to > > > be that a signal handler is being run when the SYNCQ sflag is set (but > > > the thread is not on a cv or a mutex queue), and the handler calls > > > sem_post() which is supposed to be signal safe. sem_post() tries to > > > lock a mutex and then bombs with the assertion failure. > > > > You can try: > > http://people.freebsd.org/~davidxu/kse/thr_cond.c.diff > > > > But it was not designed to fix the problem you have seen. :-) > > I think if _kse_critical_leave() were replaced by _kcb_critical_leave() > at around line 676 in thr_kern.c, that should fix the problem, no? > There's no reason to do a yield check after leaving the scheduler, > and the check for signals and cancellation is done right after > that point before returning. Well, it moved it. :) Now thr_sig_rundown() is called from thr_resume_check() from thr_sched_switch_unlocked(), but psf->valid is zero, so it still doesn't work. What would happen if the signal came in before curthread->frame was set to &psf in thread_sched_switch_unlocked()? -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org