Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 1 Nov 2007 05:59:37 +0300
From:      Andrey Chernov <ache@nagual.pp.ru>
To:        current@freebsd.org
Subject:   non-functional backout for review
Message-ID:  <20071101025937.GB94332@nagual.pp.ru>

next in thread | raw e-mail | index | archive | help
Some people complaints that new check in __isctype() is not human readable 
and requests for backout. Compiler gives almost identical code for old and 
new excepting non-optimized case where non-human readable one wins. I am a 
bit tired to change it forth and back, so ask for final consensus here.

Old one

return (_c < 0 || _c >= 128) ? 0 :

New one (requests for backout)

return (_c & ~0x7F) ? 0 :

-- 
http://ache.pp.ru/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071101025937.GB94332>