From owner-freebsd-current@FreeBSD.ORG  Thu Nov  1 03:00:20 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E220516A418
	for <current@freebsd.org>; Thu,  1 Nov 2007 03:00:20 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69])
	by mx1.freebsd.org (Postfix) with ESMTP id 66DA813C4B6
	for <current@freebsd.org>; Thu,  1 Nov 2007 03:00:20 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (ache@localhost [127.0.0.1])
	by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id lA12xbCJ094901
	for <current@freebsd.org>; Thu, 1 Nov 2007 05:59:37 +0300 (MSK)
	(envelope-from ache@nagual.pp.ru)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nagual.pp.ru;
	s=default; t=1193885977; bh=wWSKUZ6BQExPRcIOLIQ4ZPXnM05uLMWwayeswSS
	SHtI=; l=443; h=Date:From:To:Subject:Message-ID:Mail-Followup-To:
	MIME-Version:Content-Type:Content-Disposition:User-Agent; b=gpkal7
	dJ/JcxQO5rjgEp5geuVgRvbT4U9qOqUCPf6hV8gGfsnZjChcd//O85f268VkqTnbB0l
	d7LM7dni3/DcK8s7dN0BW3Dn3RyJO4LXUeMx7V2M2bf6jms3GWN1wkvQnE0pZJBmHU6
	qRJQzHPfG0Wv0lMK2Y8WOP8Q7h3qDYA=
Received: (from ache@localhost)
	by nagual.pp.ru (8.14.1/8.14.1/Submit) id lA12xbsC094900
	for current@freebsd.org; Thu, 1 Nov 2007 05:59:37 +0300 (MSK)
	(envelope-from ache)
Date: Thu, 1 Nov 2007 05:59:37 +0300
From: Andrey Chernov <ache@nagual.pp.ru>
To: current@freebsd.org
Message-ID: <20071101025937.GB94332@nagual.pp.ru>
Mail-Followup-To: Andrey Chernov <ache@nagual.pp.ru>, current@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.16 (2007-06-09)
Cc: 
Subject: non-functional backout for review
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Nov 2007 03:00:21 -0000

Some people complaints that new check in __isctype() is not human readable 
and requests for backout. Compiler gives almost identical code for old and 
new excepting non-optimized case where non-human readable one wins. I am a 
bit tired to change it forth and back, so ask for final consensus here.

Old one

return (_c < 0 || _c >= 128) ? 0 :

New one (requests for backout)

return (_c & ~0x7F) ? 0 :

-- 
http://ache.pp.ru/