Date: Wed, 28 Aug 2013 10:45:58 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: Xin LI <delphij@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r254982 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <521DAAB6.4010008@FreeBSD.org> In-Reply-To: <201308280039.r7S0dmRK082241@svn.freebsd.org> References: <201308280039.r7S0dmRK082241@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
on 28/08/2013 03:39 Xin LI said the following: > @@ -6250,8 +6250,11 @@ zfs_freebsd_rename(ap) > ASSERT(ap->a_fcnp->cn_flags & (SAVENAME|SAVESTART)); > ASSERT(ap->a_tcnp->cn_flags & (SAVENAME|SAVESTART)); > > - error = zfs_rename(fdvp, ap->a_fcnp->cn_nameptr, tdvp, > - ap->a_tcnp->cn_nameptr, ap->a_fcnp->cn_cred, NULL, 0); > + if (fdvp->v_mount == tdvp->v_mount) > + error = zfs_rename(fdvp, ap->a_fcnp->cn_nameptr, tdvp, > + ap->a_tcnp->cn_nameptr, ap->a_fcnp->cn_cred, NULL, 0); > + else > + error = EXDEV; > > if (tdvp == tvp) > VN_RELE(tdvp); So, I am still not sure if that is important or not, but this change still misses (tvp && (fvp->v_mount != tvp->v_mount)) check as found in ufs_rename. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?521DAAB6.4010008>