From owner-svn-src-head@FreeBSD.ORG Thu Nov 28 08:53:10 2013 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1B0EAD71; Thu, 28 Nov 2013 08:53:10 +0000 (UTC) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 96B851E81; Thu, 28 Nov 2013 08:53:08 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id KAA19929; Thu, 28 Nov 2013 10:53:06 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1VlxLN-0009d1-Ql; Thu, 28 Nov 2013 10:53:05 +0200 Message-ID: <52970439.3070406@FreeBSD.org> Date: Thu, 28 Nov 2013 10:52:09 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org, FreeBSD Current , freebsd-fs@FreeBSD.org Subject: Re: [HEADSUP!!!] do not upgrade to or past r258632 if you use ZFS + TRIM References: <201311260957.rAQ9vF6d004168@svn.freebsd.org> <52961B2E.1080602@FreeBSD.org> In-Reply-To: <52961B2E.1080602@FreeBSD.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Nov 2013 08:53:10 -0000 on 27/11/2013 18:17 Andriy Gapon said the following: > on 26/11/2013 11:57 Andriy Gapon said the following: >> Author: avg >> Date: Tue Nov 26 09:57:14 2013 >> New Revision: 258632 >> URL: http://svnweb.freebsd.org/changeset/base/258632 >> >> Log: >> MFV r255255: 4045 zfs write throttle & i/o scheduler performance work >> >> illumos/illumos-gate@69962b5647e4a8b9b14998733b765925381b727e >> >> Please note the following changes: >> - zio_ioctl has lost its priority parameter and now TRIM is executed >> with 'now' priority >> - some knobs are gone and some new knobs are added; not all of them are >> exposed as tunables / sysctls yet >> >> MFC after: 10 days >> Sponsored by: HybridCluster [merge] > > I think that I've introduced a very serious bug when merging this change. > Please do not upgrade to this revision if you use ZFS with SSDs and have TRIM > support enabled. > > If you have already upgraded, please disable TRIM support ASAP and roll back to > a previous version of kernel and then check integrity of your pools. The issue should be fixed in r258704. Yes, the bug was that simple and that serious. My apologies to all who were affected. -- Andriy Gapon