Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 17 Jun 2013 15:01:41 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   svn commit: r251853 - stable/8/sbin/camcontrol
Message-ID:  <201306171501.r5HF1fDf024472@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mav
Date: Mon Jun 17 15:01:40 2013
New Revision: 251853
URL: http://svnweb.freebsd.org/changeset/base/251853

Log:
  MFC r251659:
  Use CAM_DIR_NONE for requests without data.
  Wrong values there confuse some drivers.

Modified:
  stable/8/sbin/camcontrol/camcontrol.c
Directory Properties:
  stable/8/sbin/camcontrol/   (props changed)

Modified: stable/8/sbin/camcontrol/camcontrol.c
==============================================================================
--- stable/8/sbin/camcontrol/camcontrol.c	Mon Jun 17 14:59:23 2013	(r251852)
+++ stable/8/sbin/camcontrol/camcontrol.c	Mon Jun 17 15:01:40 2013	(r251853)
@@ -1716,7 +1716,7 @@ ata_read_native_max(struct cam_device *d
 	error = ata_do_cmd(device,
 			   ccb,
 			   retry_count,
-			   /*flags*/CAM_DIR_IN,
+			   /*flags*/CAM_DIR_NONE,
 			   /*protocol*/protocol,
 			   /*ata_flags*/AP_FLAG_CHK_COND,
 			   /*tag_action*/MSG_SIMPLE_Q_TAG,
@@ -1760,7 +1760,7 @@ atahpa_set_max(struct cam_device *device
 	error = ata_do_cmd(device,
 			   ccb,
 			   retry_count,
-			   /*flags*/CAM_DIR_OUT,
+			   /*flags*/CAM_DIR_NONE,
 			   /*protocol*/protocol,
 			   /*ata_flags*/AP_FLAG_CHK_COND,
 			   /*tag_action*/MSG_SIMPLE_Q_TAG,
@@ -1827,7 +1827,7 @@ atahpa_lock(struct cam_device *device, i
 	error = ata_do_cmd(device,
 			   ccb,
 			   retry_count,
-			   /*flags*/CAM_DIR_OUT,
+			   /*flags*/CAM_DIR_NONE,
 			   /*protocol*/protocol,
 			   /*ata_flags*/AP_FLAG_CHK_COND,
 			   /*tag_action*/MSG_SIMPLE_Q_TAG,
@@ -1894,7 +1894,7 @@ atahpa_freeze_lock(struct cam_device *de
 	error = ata_do_cmd(device,
 			   ccb,
 			   retry_count,
-			   /*flags*/CAM_DIR_OUT,
+			   /*flags*/CAM_DIR_NONE,
 			   /*protocol*/protocol,
 			   /*ata_flags*/AP_FLAG_CHK_COND,
 			   /*tag_action*/MSG_SIMPLE_Q_TAG,



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201306171501.r5HF1fDf024472>