From owner-freebsd-audit Tue Jul 16 15:23:39 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC9F837B405 for ; Tue, 16 Jul 2002 15:23:20 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5C21843E31 for ; Tue, 16 Jul 2002 15:23:16 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id IAA29817; Wed, 17 Jul 2002 08:22:52 +1000 Date: Wed, 17 Jul 2002 08:26:34 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Mark Murray Cc: "M. Warner Losh" , Subject: Re: bin/ln & WARNS=5 In-Reply-To: <200207161138.g6GBcguH031715@grimreaper.grondar.org> Message-ID: <20020717081218.N2535-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, 16 Jul 2002, Mark Murray wrote: > > So would you agree with: > > > > Index: style.9 > > =================================================================== > > RCS file: /cache/ncvs/src/share/man/man9/style.9,v > > retrieving revision 1.87 > > diff -u -r1.87 style.9 > > --- style.9 2 Jul 2002 01:39:35 -0000 1.87 > > +++ style.9 15 Jul 2002 18:15:58 -0000 > > @@ -520,6 +520,13 @@ > > Note that > > .Xr indent 1 > > does not understand this rule. > > +.Ic sizeof Ns 's > > +are written like function calls always. > > "are written like function calls." Oops, I agreed too fast :-). sizeof's are NOT written like function calls always. "sizeof(struct foo)" is not written like a function call. The rule should be something like something like "The argument of a sizeof is parenthesized whether or not the parentheses are required for syntactical reasons". > > +The redundant parenthesis rules do not apply to > > +.Ic sizeof(var) > > +instances. > > " ... by BSD convention.". This goes without saying (and doesn't need to be said). The whole file is about conventions. > > +Some code in the tree does not follow the last part of this rule. > > +Do not change it gratuitously to do so. > > Why not? We gratuitously remove register. The above is a rule with > no reason. Because it gives myriads of gratuitous changes. There should be a rule about not gratuitously removing register too. Actually, we already have one near the end of the file: % Stylistic changes (including whitespace changes) are hard on the source % repository and are to be avoided without good reason. My version of style.9 also has this meta-rule near the start of the file: % /* % * Internal consistency (per-file) has precedence over these rules. % */ % .Ed % .\" Most files are not internally consistent, so these rules usually % .\" apply :-). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message