Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 11 Jan 2017 13:35:50 -0800
From:      Ngie Cooper <yaneurabeya@gmail.com>
To:        Dimitry Andric <dim@freebsd.org>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>,  "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,  "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r311929 - head/sys/boot/common
Message-ID:  <CAGHfRMBy7KPP=vLjEpyfRuf_u4S%2B2mO_W3US9WodMf=ckRJKBQ@mail.gmail.com>
In-Reply-To: <201701111847.v0BIl0Mg013954@repo.freebsd.org>
References:  <201701111847.v0BIl0Mg013954@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 11, 2017 at 10:47 AM, Dimitry Andric <dim@freebsd.org> wrote:
> Author: dim
> Date: Wed Jan 11 18:47:00 2017
> New Revision: 311929
> URL: https://svnweb.freebsd.org/changeset/base/311929
>
> Log:
>   Don't include <errno.h> in reloc_elf.c, as it includes <stand.h> just
>   after it, which has a conflicting definition of errno.  This leads to
>   the following warning with clang 4.0.0:
>
>       In file included from sys/boot/common/reloc_elf32.c:6:
>       In file included from sys/boot/common/reloc_elf.c:37:
>       /usr/obj/usr/src/tmp/usr/include/stand.h:155:12: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
>       extern int errno;
>                  ^
>       sys/sys/errno.h:46:26: note: expanded from macro 'errno'
>       #define errno           (* __error())

It seems like libstand (once again) should be fixed, not the "offending code".
-Ngie



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMBy7KPP=vLjEpyfRuf_u4S%2B2mO_W3US9WodMf=ckRJKBQ>