Date: Mon, 16 Apr 2018 21:20:34 +0000 (UTC) From: Michael Tuexen <tuexen@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: svn commit: r332636 - in stable/11/sys: netinet netinet6 Message-ID: <201804162120.w3GLKYmU051958@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: tuexen Date: Mon Apr 16 21:20:34 2018 New Revision: 332636 URL: https://svnweb.freebsd.org/changeset/base/332636 Log: MFC r332273: Fix a logical inversion bug. Thanks to Irene Ruengeler for finding and reporting this bug. Modified: stable/11/sys/netinet/sctp_usrreq.c stable/11/sys/netinet6/sctp6_usrreq.c Directory Properties: stable/11/ (props changed) Modified: stable/11/sys/netinet/sctp_usrreq.c ============================================================================== --- stable/11/sys/netinet/sctp_usrreq.c Mon Apr 16 21:18:44 2018 (r332635) +++ stable/11/sys/netinet/sctp_usrreq.c Mon Apr 16 21:20:34 2018 (r332636) @@ -202,7 +202,7 @@ sctp_notify(struct sctp_inpcb *inp, #endif /* no need to unlock here, since the TCB is gone */ } else if (icmp_code == ICMP_UNREACH_NEEDFRAG) { - if ((net->dest_state & SCTP_ADDR_NO_PMTUD) == 0) { + if (net->dest_state & SCTP_ADDR_NO_PMTUD) { SCTP_TCB_UNLOCK(stcb); return; } Modified: stable/11/sys/netinet6/sctp6_usrreq.c ============================================================================== --- stable/11/sys/netinet6/sctp6_usrreq.c Mon Apr 16 21:18:44 2018 (r332635) +++ stable/11/sys/netinet6/sctp6_usrreq.c Mon Apr 16 21:20:34 2018 (r332636) @@ -221,7 +221,7 @@ sctp6_notify(struct sctp_inpcb *inp, } break; case ICMP6_PACKET_TOO_BIG: - if ((net->dest_state & SCTP_ADDR_NO_PMTUD) == 0) { + if (net->dest_state & SCTP_ADDR_NO_PMTUD) { SCTP_TCB_UNLOCK(stcb); break; }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201804162120.w3GLKYmU051958>