From owner-svn-src-head@FreeBSD.ORG Wed Aug 14 07:25:18 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id E2D08428; Wed, 14 Aug 2013 07:25:18 +0000 (UTC) (envelope-from dim@freebsd.org) Received: from tensor.andric.com (unknown [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A5CA92452; Wed, 14 Aug 2013 07:25:18 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::64a4:45e2:b359:2420] (unknown [IPv6:2001:7b8:3a7:0:64a4:45e2:b359:2420]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id AC38F5C43; Wed, 14 Aug 2013 09:25:15 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: svn commit: r254286 - head/sys/fs/ext2fs From: Dimitry Andric In-Reply-To: Date: Wed, 14 Aug 2013 09:25:15 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201308131839.r7DIdaLD037277@svn.freebsd.org> <9B5BBD34-F953-40BF-8C10-0EF466ED3350@FreeBSD.org> To: Juli Mallett X-Mailer: Apple Mail (2.1508) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, "Pedro F. Giffuni" , src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2013 07:25:19 -0000 On Aug 14, 2013, at 09:14, Juli Mallett wrote: > On Wed, Aug 14, 2013 at 12:11 AM, Dimitry Andric = wrote: > This still fails on arches where int64_t is aliased to long long > (basically, the 32-bit arches). Since using PRId64 is apparently > frowned upon, the easiest solution is to cast the 'start' and 'last' > variables to long long, and print them using %lld. >=20 > That can't be the easiest solution, it's not even that easy :) It = seems like intmax_t or uintmax_t as appropriate and cast to %jd or %ju = respectively would be better. I was simply looking at the surrounding code, and that already casts several items to long long. So I wanted to keep the style there. :-) -Dimitry