From owner-svn-src-head@FreeBSD.ORG  Wed Oct 22 22:32:41 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D7809415;
 Wed, 22 Oct 2014 22:32:41 +0000 (UTC)
Received: from mail-ie0-x22b.google.com (mail-ie0-x22b.google.com
 [IPv6:2607:f8b0:4001:c03::22b])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 89EEED7B;
 Wed, 22 Oct 2014 22:32:41 +0000 (UTC)
Received: by mail-ie0-f171.google.com with SMTP id x19so3888400ier.2
 for <multiple recipients>; Wed, 22 Oct 2014 15:32:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:from:date:message-id
 :subject:to:cc:content-type;
 bh=eCH+hfnryxpP9QEc2ew1qOgnNWHU4TllKoDTlxp03nQ=;
 b=t9atySkb7NX/0Oz/Ktc/XxhEo9AQ7I5AslWg5eXMDt9+L3C8ALSP2lO/VttvxA0odf
 2D9rhff1oh8IT9HEeMIFOk013TLwpCiSHQu1DUz1KyMgYc07Q4PAP6kpLpfnEbKN6jOv
 zfylJRNdzPyac6N7EZjRyivBFV5WffmfpBd4H0hcMw5C//F9Hu9MrZ/7GjrT3otukDsX
 f+GT0E2fKDS7ZUkP6/UeQJT4YaLJ1/9s/T5x0CMjLhl+HDDSh5i/LIzYcCZRj7fThppP
 9B4IUz0ydwAGrbKlZVYO91iihyApOH0Cb4SsnsZUfwv/rRb1X0+CFtR2Y3jjucfdoVGP
 tNIw==
X-Received: by 10.43.153.131 with SMTP id la3mr7086907icc.38.1414017160960;
 Wed, 22 Oct 2014 15:32:40 -0700 (PDT)
MIME-Version: 1.0
Sender: carpeddiem@gmail.com
Received: by 10.107.29.132 with HTTP; Wed, 22 Oct 2014 15:32:20 -0700 (PDT)
In-Reply-To: <201410222047.s9MKlBut062991@svn.freebsd.org>
References: <201410222047.s9MKlBut062991@svn.freebsd.org>
From: Ed Maste <emaste@freebsd.org>
Date: Wed, 22 Oct 2014 18:32:20 -0400
X-Google-Sender-Auth: hTFXJzmWe54MBh9QCt3XeeeH2UM
Message-ID: <CAPyFy2B19XkRQKAxpnTcfEjkG+=ZjYW2Z1+nR=yWQRfR9yytgQ@mail.gmail.com>
Subject: Re: svn commit: r273481 - head/sys/fs/nfsclient
To: Rick Macklem <rmacklem@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Oct 2014 22:32:42 -0000

On 22 October 2014 16:47, Rick Macklem <rmacklem@freebsd.org> wrote:
> Author: rmacklem
> Date: Wed Oct 22 20:47:11 2014
> New Revision: 273481
> URL: https://svnweb.freebsd.org/changeset/base/273481
>
> Log:
>   Clip the settings for the NFS rsize, wsize mount options
>   to a power of 2.

For what it's worth, I fixed a similar issue in r248500 a while back.
It was an NFS bug and resulted in data corruption instead of a crash.
Anyhow, it appears these cases are not well tested so it does seem
reasonable to avoid them.

-Ed